Skip to contentSkip to conversation

vm: weird behaviour when munmapping

DISCUSSION moreau francis 2 participants 2 messages Nov 17, 2006

lore
Share & tools
lore
#0 lore raw
Quoted 15 lines · Peter Zijlstra
Quoted 3 lines · moreau francis

lower vma: 0x2aaae000 -> 0x2aaaf000
upper vma: 0x2aaaf000 -> 0x2aab2000

that is the remaining VMA, not the new one; we trigger this code:

    /* Does it split the last one? */
    last = find_vma(mm, end);
    if (last && end > last->vm_start) {
        int error = split_vma(mm, last, end, 1);
        if (error)
            return error;
    }
Quoted 7 lines

So, since its the last VMA that needs to be split (there is only one), the new VMA is constructed before the old one. Like so:

AAAAAAAAAAAAAAAAAAAAA
BBBBAAAAAAAAAAAAAAAAA

Then you proceed closing, in this case the new one: B.

Sorry but I don't understand why B is said to be the new one. OK I can see why from the bit of code you pointed out but from a logical point of view (ok maybe be me only) I'm unmapping 'BBBB' segment, so 'BBBB' is going to be destroyed and therefore A is the new one. Thereferore I would expect close(B), open(A)...

no ?

Francis

___________________________________________________________________________
Découvrez une nouvelle façon d'obtenir des réponses à toutes vos questions !
Profitez des connaissances, des opinions et des expériences des internautes sur Yahoo! Questions/Réponses
http://fr.answers.yahoo.com

#1 lore raw
Quoted 24 lines · moreau francis
Quoted 15 lines · Peter Zijlstra
Quoted 3 lines · moreau francis

lower vma: 0x2aaae000 -> 0x2aaaf000
upper vma: 0x2aaaf000 -> 0x2aab2000

that is the remaining VMA, not the new one; we trigger this code:

    /* Does it split the last one? */
    last = find_vma(mm, end);
    if (last && end > last->vm_start) {
        int error = split_vma(mm, last, end, 1);
        if (error)
            return error;
    }
Quoted 7 lines

So, since its the last VMA that needs to be split (there is only one), the new VMA is constructed before the old one. Like so:

AAAAAAAAAAAAAAAAAAAAA
BBBBAAAAAAAAAAAAAAAAA

Then you proceed closing, in this case the new one: B.

Quoted 7 lines

Sorry but I don't understand why B is said to be the new one. OK I can see why from the bit of code you pointed out but from a logical point of view (ok maybe be me only) I'm unmapping 'BBBB' segment, so 'BBBB' is going to be destroyed and therefore A is the new one. Thereferore I would expect close(B), open(A)...

no ?

No indeed. You seem confused with remaining and new.

It has one VMA (A) it needs to split that into two pieces, it happens to do it like (B,A') where A' is the old VMA object with new a start address, and B is a new VMA object.

If you'd unmapped the tail end of your region you'd then see a close of A' but you happen to unmap the head so you'll see B closed.

vm_ops->open() is called on new VMA objects, in this scenario B is the only new object created. A -> A' is not creating a new object just modifying an old one.