Skip to contentSkip to conversation

Networking: re-fix of doc-comment in sock.h

PATCH Applied Paul Bonser 2 participants 2 messages Nov 18, 2006 – Nov 24, 2006

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Networking: re-fix of doc-comment in sock.h

From: Paul Bonser <[email protected]>

Restoring old, correct comment for sk_filter_release, moving it to where it should actually be, and changing new comment into proper comment for sk_filter_rcu_free, where it actually makes sense.

The original fix submitted for this on Oct 23 mistakenly documented the wrong function.

---

include/net/sock.h +10 -5
index ac286a3..9cdbae2 100644
@@ -883,18 +883,23 @@ static inline int sk_filter(struct sock 
 }
 
 /**
- *	sk_filter_release: Release a socket filter
- *	@rcu: rcu_head that contains the sk_filter info to remove
- *
- *	Remove a filter from a socket and release its resources.
+ * 	sk_filter_rcu_free: Free a socket filter
+ *	@rcu: rcu_head that contains the sk_filter to free
  */
- 
 static inline void sk_filter_rcu_free(struct rcu_head *rcu)
 {
 	struct sk_filter *fp = container_of(rcu, struct sk_filter, rcu);
 	kfree(fp);
 }
 
+/**
+ *	sk_filter_release: Release a socket filter
+ *	@sk: socket
+ *	@fp: filter to remove
+ *
+ *	Remove a filter from a socket and release its resources.
+ */
+
 static inline void sk_filter_release(struct sock *sk, struct sk_filter *fp)
 {
 	unsigned int size = sk_filter_len(fp);
maintainer Applied
#1 lore raw

From: Paul Bonser <[email protected]>
Date: Sat, 18 Nov 2006 00:27:27 -0800

Quoted 7 lines

From: Paul Bonser <[email protected]>

Restoring old, correct comment for sk_filter_release, moving it to where it should actually be, and changing new comment into proper comment for sk_filter_rcu_free, where it actually makes sense.

The original fix submitted for this on Oct 23 mistakenly documented the wrong function.

Applied, thanks.