Skip to contentSkip to conversation

ipath uses skb functions

DISCUSSION Applied Randy Dunlap 3 participants 4 messages Nov 19, 2006 – Nov 20, 2006 InfiniBand

lore
Share & tools
lore
#0 lore raw

but doesn't depends on NET (Networking).

drivers/built-in.o: In function `ipath_free_pddata':
(.text.ipath_free_pddata+0x155): undefined reference to kfree_skb' drivers/built-in.o: In function ipath_alloc_skb':
(.text.ipath_alloc_skb+0x28): undefined reference to __alloc_skb' drivers/built-in.o: In function ipath_init_chip':
(.text.ipath_init_chip+0xe61): undefined reference to `kfree_skb'
make: *** [vmlinux] Error 1

2.6.19-rc6-git2

---
~Randy

#1 lore raw
Quoted 1 line · Randy Dunlap

but doesn't depends on NET (Networking).

Thanks. One-liner patch attached. Roland, please add this to your for-2.6.19 or for-2.6.20 queue, as you see fit.

	<b

IB/ipath - make Kconfig depend on CONFIG_NET

Spotted by Randy Dunlap.

drivers/infiniband/hw/ipath/Kconfig +1 -1
diff -r 9769053d8f77 drivers/infiniband/hw/ipath/Kconfig
@@ -1,6 +1,6 @@ config INFINIBAND_IPATH
 config INFINIBAND_IPATH
 	tristate "QLogic InfiniPath Driver"
-	depends on (PCI_MSI || HT_IRQ) && 64BIT && INFINIBAND
+	depends on (PCI_MSI || HT_IRQ) && 64BIT && INFINIBAND && NET
 	---help---
 	This is a driver for QLogic InfiniPath host channel adapters,
 	including InfiniBand verbs support.  This driver allows these
author Acked-by
#2 lore raw
Quoted 6 lines · Bryan O'Sullivan
Quoted 1 line · Randy Dunlap

but doesn't depends on NET (Networking).

Thanks. One-liner patch attached. Roland, please add this to your for-2.6.19 or for-2.6.20 queue, as you see fit.

    <b
Quoted 19 lines

------------------------------------------------------------------------

IB/ipath - make Kconfig depend on CONFIG_NET

Spotted by Randy Dunlap.

diff -r 9769053d8f77 drivers/infiniband/hw/ipath/Kconfig

drivers/infiniband/hw/ipath/Kconfig +1 -1
@@ -1,6 +1,6 @@ config INFINIBAND_IPATH
 config INFINIBAND_IPATH
 	tristate "QLogic InfiniPath Driver"
-	depends on (PCI_MSI || HT_IRQ) && 64BIT && INFINIBAND
+	depends on (PCI_MSI || HT_IRQ) && 64BIT && INFINIBAND && NET
 	---help---
 	This is a driver for QLogic InfiniPath host channel adapters,
 	including InfiniBand verbs support.  This driver allows these
Signature · 1 line
~Randy