Skip to contentSkip to conversation

SuperIO locks coordinator - use in

PATCH New Jean Delvare 1 participant 1 message Nov 19, 2006

lore
Share & tools
lore
#0 lore raw

PATCH 3/3 SuperIO locks coordinator - use in

Quoted 12 lines · David Hubbard

Now, I'm not the most knowledgeable one about the I2C subsystem, but I believe that w83627ehf_driver is redeclared a little later with this:

static struct i2c_driver w83627ehf_driver = {
	.driver = {
		.name	= "w83627ehf",
	},
	.attach_adapter	= w83627ehf_detect,
	.detach_client	= w83627ehf_detach_client,
};
Quoted 2 lines

Jean mentioned that it might be a good idea to define .name at runtime, depending on whether a w83627ehf or a w83627dhg was detected.

No, the name which depends on the device is the (surprise!) device name, not the driver name. As the w83627ehf driver currently is based on i2c-isa, this is the name field of an i2c_client structure. The driver name must match the source file name, so it's not supposed to change.

Signature · 1 line
Jean Delvare