Skip to contentSkip to conversation

Remove #warning cruft from drivers/scsi/ips.c

PATCH In review Michael Ellerman 2 participants 3 messages Nov 21, 2006

Subsystems (3)
SCSI IBM ServeRAID RAID driver Ips SCSI RAID driver
lore
Share & tools
lore

Michael Ellerman

author
#0 lore raw

PATCH 1/1 Remove #warning cruft from drivers/scsi/ips.c

drivers/scsi/ips.c pollutes my build log telling me that it has only been tested on x86/ia64/x86_64. It's starting to get annoying.

Replace the #warning with a simple comment.

Signed-off-by Michael Ellerman <[email protected]>

---

 drivers/scsi/ips.c |    6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
drivers/scsi/ips.c +2 -4
Index: msi/drivers/scsi/ips.c
===================================================================
@@ -8,6 +8,8 @@
 /* Copyright (C) 2000 IBM Corporation                                        */
 /* Copyright (C) 2002,2003 Adaptec, Inc.                                     */
 /*                                                                           */
+/* This driver has only been tested on the x86/ia64/x86_64 platforms.        */
+/*                                                                           */
 /* This program is free software; you can redistribute it and/or modify      */
 /* it under the terms of the GNU General Public License as published by      */
 /* the Free Software Foundation; either version 2 of the License, or         */

@@ -207,10 +209,6 @@ module_param(ips, charp, 0);
 #define IPS_VERSION_HIGH        "7.12"
 #define IPS_VERSION_LOW         ".05 "
 
-#if !defined(__i386__) && !defined(__ia64__) && !defined(__x86_64__)
-#warning "This driver has only been tested on the x86/ia64/x86_64 platforms"
-#endif
-
 #if LINUX_VERSION_CODE <= KERNEL_VERSION(2,5,0)
 #include <linux/blk.h>
 #include "sd.h"
#1 lore raw
Quoted 2 lines · Michael Ellerman

drivers/scsi/ips.c pollutes my build log telling me that it has only been tested on x86/ia64/x86_64. It's starting to get annoying.

Since we have a failure report for this driver on the ppc platform, I don't necessarily see the warning as being inappropriate.

James

author
#2 lore raw
Quoted 6 lines · James Bottomley
Quoted 2 lines · Michael Ellerman

drivers/scsi/ips.c pollutes my build log telling me that it has only been tested on x86/ia64/x86_64. It's starting to get annoying.

Since we have a failure report for this driver on the ppc platform, I don't necessarily see the warning as being inappropriate.

If it's known not to work, why are we building it at all for ppc?

cheers

Signature · 8 lines
Michael Ellerman
OzLabs, IBM Australia Development Lab

wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)

We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person