i386/x86_64: remove the unused EXPORT_SYMBOL(dump_trace)
PATCH 1/1 i386/x86_64: remove the unused EXPORT_SYMBOL(dump_trace)
This patch removes the unused EXPORT_SYMBOL(dump_trace) added on i386 and x86_64 in 2.6.19-rc.
By removing them before the final 2.6.19 we avoid the possibility of people later whining that we removed exports they started using.
---
arch/i386/kernel/traps.c | 1 - arch/x86_64/kernel/traps.c | 1 - 2 files changed, 2 deletions(-)
arch/i386/kernel/traps.c renamed from arch/i386/kernel/traps.c.old +0 -1
@@ -247,7 +247,6 @@break ; } } -EXPORT_SYMBOL (dump_trace);static void print_trace_warning_symbol (void *data,char *msg,unsigned long symbol)
arch/x86_64/kernel/traps.c renamed from arch/x86_64/kernel/traps.c.old +0 -1
@@ -377,7 +377,6 @@ out:put_cpu (); } -EXPORT_SYMBOL (dump_trace);static void print_trace_warning_symbol (void *data,char *msg,unsigned long symbol)
Quoted 5 lines · Adrian Bunk
This patch removes the unused
EXPORT_SYMBOL(dump_trace)added on i386 andx86_64in 2.6.19-rc.By removing them before the final 2.6.19 we avoid the possibility of people later whining that we removed exports they started using.
I exported it for systemtap so that they can stop using the broken hack they currently use as unwinder.
-Andi
Quoted 9 lines · Andi Kleen
Quoted 5 lines · Adrian Bunk
This patch removes the unused
EXPORT_SYMBOL(dump_trace)added on i386 andx86_64in 2.6.19-rc.By removing them before the final 2.6.19 we avoid the possibility of people later whining that we removed exports they started using.
I exported it for systemtap so that they can stop using the broken hack they currently use as unwinder.
Nack, dump_trace is nothing that should be export for broken out of tree junk.
Quoted 5 lines · On Tue, 21 Nov 2006 20:18:44 +0000 Christoph Hellwig <[email protected]> wrote:
Quoted 4 lines · Andi Kleen
Quoted 3 lines · Adrian Bunk
This patch removes the unused
EXPORT_SYMBOL(dump_trace)added on i386 andx86_64in 2.6.19-rc.
Quoted 8 lines
Quoted 5 lines
Quoted 2 lines
By removing them before the final 2.6.19 we avoid the possibility of people later whining that we removed exports they started using.
I exported it for systemtap so that they can stop using the broken hack they currently use as unwinder.
Nack,
dump_traceis nothing that should be export for broken out of tree junk.
It is exported for systemtap not random broken out of tree junk, and the result is a good deal prettier. Systemtap guys really ought to get their stuff merged too, although how we merge a dynamic module writing tool I'm not so sure ?
Alan
Quoted 27 lines · Alan
Quoted 13 lines · On Tue, 21 Nov 2006 20:18:44 +0000 Christoph Hellwig <[email protected]> wrote:
Quoted 10 lines · Andi Kleen
Quoted 7 lines · Adrian Bunk
This patch removes the unused
EXPORT_SYMBOL(dump_trace)added on i386 andx86_64in 2.6.19-rc.By removing them before the final 2.6.19 we avoid the possibility of people later whining that we removed exports they started using.
Quoted 8 lines
Quoted 4 lines
I exported it for systemtap so that they can stop using the broken hack they currently use as unwinder.
Nack,
dump_traceis nothing that should be export for broken out of tree junk.
Quoted 7 lines
It is exported for systemtap not random broken out of tree junk, and the result is a good deal prettier. Systemtap guys really ought to get their stuff merged too, although how we merge a dynamic module writing tool I'm not so sure ?
As you all know SystemTap uses kprobes and relayfs as the basis which are already merged into the mainline.
We are looking at all the other pieces of SystemTap that can be merged to mainline but as Alan mentioned it is not easy and obvious. We think we can merge transport part of the runtime, here is the initial patch under review in this thread
http://sources.redhat.com/ml/systemtap/2006-q4/msg00031.html
http://sources.redhat.com/ml/systemtap/2006-q4/msg00030.html
We are open for other suggestions as well.
bye,
Vara Prasad
Quoted 9 lines
Alan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/