ata: fix platform_device_register_simple() error check
PATCH 1/1 ata: fix platform_device_register_simple() error check
The return value of platform_device_register_simple() should be checked by IS_ERR().
Cc Jeff Garzik <[email protected]>
Cc Alan <[email protected]>
Signed-off-by Akinobu Mita <[email protected]>
--- drivers/ata/pata_legacy.c | 4 +++- drivers/ata/pata_qdi.c | 4 ++-- drivers/ata/pata_winbond.c | 4 ++-- 3 files changed, 7 insertions(+), 5 deletions(-)
drivers/ata/pata_legacy.c +3 -1
@@ -698,8 +698,10 @@ static __init int legacy_init_one(int po goto fail_io; pdev =platform_device_register_simple (DRV_NAME , nr_legacy_host,NULL ,0 ); -if (pdev ==NULL ) +if (IS_ERR (pdev)) { + ret =PTR_ERR (pdev); goto fail_dev; + }if (ht6560a & mask) { ops = &ht6560a_port_ops;
drivers/ata/pata_qdi.c +2 -2
@@ -247,8 +247,8 @@ static __init int qdi_init_one(unsigned*/ pdev =platform_device_register_simple (DRV_NAME , nr_qdi_host,NULL ,0 ); -if (pdev ==NULL ) -return -ENOMEM ; +if (IS_ERR (pdev)) +return PTR_ERR (pdev);memset (&ae,0 ,sizeof (struct ata_probe_ent ));INIT_LIST_HEAD (&ae.node);
drivers/ata/pata_winbond.c +2 -2
@@ -206,8 +206,8 @@ static __init int winbond_init_one(unsig*/ pdev =platform_device_register_simple (DRV_NAME , nr_winbond_host,NULL ,0 ); -if (pdev ==NULL ) -return -ENOMEM ; +if (IS_ERR (pdev)) +return PTR_ERR (pdev);memset (&ae,0 ,sizeof (struct ata_probe_ent ));INIT_LIST_HEAD (&ae.node);
Quoted 6 lines · On Thu, 23 Nov 2006 03:47:55 +0900 Akinobu Mita <[email protected]> wrote:
The return value of
platform_device_register_simple()should be checked byIS_ERR().Cc Jeff Garzik <[email protected]>Cc Alan <[email protected]>Signed-off-by Akinobu Mita <[email protected]>
Thanks for noticing that one.
Acked-by Alan Cox <[email protected]>