Skip to contentSkip to conversation

irda compile broken

BUG Peter Zijlstra 2 participants 2 messages Nov 23, 2006 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw
Quoted 10 lines · Rolf Eike Beer

Peter tried to fix a IRDA lockdep warning by commit 700f9672c9a61c12334651a94d17ec04620e1976. The commit message says: "it just needs a lockdep annotation."

Compiling this gives:

WARNING: "spin_lock_irqsave_nested" [net/irda/irda.ko] undefined!

The only point in the whole kernel tree where spin_lock_irqsave_nested appears is in this file. Maybe this patch was meant to go into -mm and stay there?

The original mail also contained this:
(depends on patches in -mm for spin_lock_irqsave_nested())

Anyway, it has already been noticed, and Andrew will send the needed bits upwards.

http://lkml.org/lkml/2006/11/22/283

#2 lore raw
In reply to a message not in the archive

From: Rolf Eike Beer <[email protected]>
Date: Thu, 23 Nov 2006 10:23:28 +0100

Quoted 10 lines

Peter tried to fix a IRDA lockdep warning by commit 700f9672c9a61c12334651a94d17ec04620e1976. The commit message says: "it just needs a lockdep annotation."

Compiling this gives:

WARNING: "spin_lock_irqsave_nested" [net/irda/irda.ko] undefined!

The only point in the whole kernel tree where spin_lock_irqsave_nested appears is in this file. Maybe this patch was meant to go into -mm and stay there?

As Andrew posted elsewhere, I accidently put that change in before the infrastructure, and Andrew will push the necessary infrastructure patch to Linus to fix this build failure.

Sorry for that, but it'll get fixed up soon.