Skip to contentSkip to conversation

make drivers/mtd/cmdlinepart.c:mtdpart_setup() static

PATCH Applied Adrian Bunk 4 participants 4 messages Nov 25, 2006 – Dec 1, 2006 Memory technology devices (MTD)

lore
Share & tools
lore

Adrian Bunk

author
#0 lore raw

PATCH 1/1 make drivers/mtd/cmdlinepart.c:mtdpart_setup() static

This patch makes the needlessly global mtdpart_setup() static.

Signed-off-by Adrian Bunk <[email protected]>

---

This patch was already sent on:
- 27 Jun 2006

drivers/mtd/cmdlinepart.c renamed from drivers/mtd/cmdlinepart.c.old +1 -1
@@ -346,7 +346,7 @@
  *
  * This function needs to be visible for bootloaders.
  */
-int mtdpart_setup(char *s)
+static int mtdpart_setup(char *s)
 {
 	cmdline = s;
 	return 1;
#2 lore raw

drivers/mtd/cmdlinepart.c line 352

Quoted 11 lines · Adrian Bunk

This patch makes the needlessly global mtdpart_setup() static.

drivers/mtd/cmdlinepart.c renamed from drivers/mtd/cmdlinepart.c.old +1 -1
@@ -346,7 +346,7 @@
  *
  * This function needs to be visible for bootloaders.
  */
-int mtdpart_setup(char *s)
+static int mtdpart_setup(char *s)
 {
 	cmdline = s;
 	return 1;

Jarkko,

You're recorded as submitting the original patch to make this non-static:
http://linux.bkbits.net:8080/linux-2.6/diffs/drivers/mtd/[email protected]?nav=index.html|src/|src/drivers|src/drivers/mtd|hist/drivers/mtd/cmdlinepart.c

Is this change correct?

If so, it should also delete the "needs to be visible" comment.

-andy

#3 lore raw

Our bootloader once used mtdpart_setup() for passing mtd partitions to kernel. We do not do that any more and instead use the kernel command line for passing the information.

Jarkko Lavinen

Quoted 24 lines · ext Andy Isaacson

drivers/mtd/cmdlinepart.c line 352

Quoted 11 lines · Adrian Bunk

This patch makes the needlessly global mtdpart_setup() static.

drivers/mtd/cmdlinepart.c renamed from drivers/mtd/cmdlinepart.c.old +1 -1
@@ -346,7 +346,7 @@
  *
  * This function needs to be visible for bootloaders.
  */
-int mtdpart_setup(char *s)
+static int mtdpart_setup(char *s)
 {
 	cmdline = s;
 	return 1;

Jarkko,

You're recorded as submitting the original patch to make this non-static:
http://linux.bkbits.net:8080/linux-2.6/diffs/drivers/mtd/[email protected]?nav=index.html|src/|src/drivers|src/drivers/mtd|hist/drivers/mtd/cmdlinepart.c

Is this change correct?

If so, it should also delete the "needs to be visible" comment.

-andy