jfs: incorrect use of "&&" instead of "&"
Hi Dave,
I'm about to merge this fix in 2.4. It's already in 2.6 BTW. Do you have any objection ?
Thanks in advance,
Willy
Quoted 1 line
From
b14cb91c6621908f8e957aad5a85d6c41b31dfeaMon Sep 17 00:00:00 2001
From: Willy Tarreau <[email protected]>
Date: Sat, 25 Nov 2006 21:57:26 +0100
Subject: [PATCH] jfs: incorrect use of "&&" instead of "&"
in jfs_txnmgr, the use of "tblk->flag && COMMIT_DELETE" in a if() condition is obviously wrong. This bug has already been fixed in 2.6.
--- fs/jfs/jfs_txnmgr.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
fs/jfs/jfs_txnmgr.c +1 -1
@@ -1175,7 +1175,7 @@ int txCommit(tid_t tid, /* transaction jfs_ip =JFS_IP (ip);if (test_and_clear_cflag (COMMIT_Syncdata, ip) && - ((tblk->flag &&COMMIT_DELETE ) ==0 )) + ((tblk->flag &COMMIT_DELETE ) ==0 ))fsync_inode_data_buffers (ip);/*
Signature · 1 line
1.4.2.4
Dave Kleikamp
Acked-byQuoted 4 lines · Willy Tarreau
Hi Dave,
I'm about to merge this fix in 2.4. It's already in 2.6 BTW. Do you have any objection ?
No objection.
Quoted 9 lines
Thanks in advance,
WillyFrom
b14cb91c6621908f8e957aad5a85d6c41b31dfeaMon Sep 17 00:00:00 2001
From: Willy Tarreau <[email protected]>
Date: Sat, 25 Nov 2006 21:57:26 +0100
Subject: [PATCH] jfs: incorrect use of "&&" instead of "&"
Quoted 5 lines
in
jfs_txnmgr, the use of "tblk->flag&&COMMIT_DELETE" in aif()condition is obviously wrong. This bug has already been fixed in 2.6.Signed-off-by Willy Tarreau <[email protected]>
Quoted 17 lines
--- fs/jfs/jfs_txnmgr.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)fs/jfs/jfs_txnmgr.c +1
-1@@ -1175,7 +1175,7 @@ int txCommit(tid_t tid, /* transaction jfs_ip =JFS_IP (ip);if (test_and_clear_cflag (COMMIT_Syncdata, ip) && - ((tblk->flag &&COMMIT_DELETE ) ==0 )) + ((tblk->flag &COMMIT_DELETE ) ==0 ))fsync_inode_data_buffers (ip);/*
Signature · 2 lines
David Kleikamp IBM Linux Technology Center
Willy Tarreau
AppliedQuoted 7 lines · Dave Kleikamp
Quoted 4 lines · Willy Tarreau
Hi Dave,
I'm about to merge this fix in 2.4. It's already in 2.6 BTW. Do you have any objection ?
No objection.
Thanks, applied.
Willy