Skip to contentSkip to conversation

iscsi: fix crypto_alloc_hash() error check

PATCH New Akinobu Mita 1 participant 1 message Nov 27, 2006

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 iscsi: fix crypto_alloc_hash() error check

The return value of crypto_alloc_hash() should be checked by IS_ERR().

Cc Dmitry Yusupov <[email protected]>
Cc Alex Aizman <[email protected]>
---
 drivers/scsi/iscsi_tcp.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/scsi/iscsi_tcp.c +2 -2
Index: work-fault-inject/drivers/scsi/iscsi_tcp.c
===================================================================
@@ -1777,13 +1777,13 @@ iscsi_tcp_conn_create(struct iscsi_cls_s
 	tcp_conn->tx_hash.tfm = crypto_alloc_hash("crc32c", 0,
 						  CRYPTO_ALG_ASYNC);
 	tcp_conn->tx_hash.flags = 0;
-	if (!tcp_conn->tx_hash.tfm)
+	if (IS_ERR(tcp_conn->tx_hash.tfm))
 		goto free_tcp_conn;
 
 	tcp_conn->rx_hash.tfm = crypto_alloc_hash("crc32c", 0,
 						  CRYPTO_ALG_ASYNC);
 	tcp_conn->rx_hash.flags = 0;
-	if (!tcp_conn->rx_hash.tfm)
+	if (IS_ERR(tcp_conn->rx_hash.tfm))
 		goto free_tx_tfm;
 
 	return cls_conn;