Skip to contentSkip to conversation

char: drivers use/need PCI

PATCH In review Randy Dunlap 3 participants 6 messages Nov 29, 2006 Char and misc drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 char: drivers use/need PCI

From: Randy Dunlap <[email protected]>

With CONFIG_PCI=n:
drivers/char/mxser_new.c: In function 'mxser_release_res':
drivers/char/mxser_new.c:2383: warning: implicit declaration of function 'pci_release_region' drivers/char/mxser_new.c: In function 'mxser_probe':
drivers/char/mxser_new.c:2578: warning: implicit declaration of function 'pci_request_region' drivers/built-in.o: In function `sx_remove_card':
sx.c:(.text.sx_remove_card+0x65): undefined reference to `pci_release_region' drivers/char/isicom.c: In function 'isicom_probe':
drivers/char/isicom.c:1793: warning: implicit declaration of function 'pci_request_region' drivers/char/isicom.c:1827: warning: implicit declaration of function 'pci_release_region'

---
 drivers/char/Kconfig |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/char/Kconfig +3 -3
@@ -203,7 +203,7 @@ config MOXA_SMARTIO
 
 config MOXA_SMARTIO_NEW
 	tristate "Moxa SmartIO support v. 2.0 (EXPERIMENTAL)"
-	depends on SERIAL_NONSTANDARD
+	depends on SERIAL_NONSTANDARD && PCI
 	help
 	  Say Y here if you have a Moxa SmartIO multiport serial card and/or
 	  want to help develop a new version of this driver.
@@ -218,7 +218,7 @@ config MOXA_SMARTIO_NEW
 
 config ISI
 	tristate "Multi-Tech multiport card support (EXPERIMENTAL)"
-	depends on SERIAL_NONSTANDARD
+	depends on SERIAL_NONSTANDARD && PCI
 	select FW_LOADER
 	help
 	  This is a driver for the Multi-Tech cards which provide several
@@ -312,7 +312,7 @@ config SPECIALIX_RTSCTS
 
 config SX
 	tristate "Specialix SX (and SI) card support"
-	depends on SERIAL_NONSTANDARD
+	depends on SERIAL_NONSTANDARD && PCI
 	help
 	  This is a driver for the SX and SI multiport serial cards.
 	  Please read the file <file:Documentation/sx.txt> for details.

---

#1 lore raw
Quoted 39 lines · Randy Dunlap

From: Randy Dunlap <[email protected]>

With CONFIG_PCI=n:
drivers/char/mxser_new.c: In function 'mxser_release_res':
drivers/char/mxser_new.c:2383: warning: implicit declaration of function 'pci_release_region' drivers/char/mxser_new.c: In function 'mxser_probe':
drivers/char/mxser_new.c:2578: warning: implicit declaration of function 'pci_request_region' drivers/built-in.o: In function `sx_remove_card':
sx.c:(.text.sx_remove_card+0x65): undefined reference to `pci_release_region' drivers/char/isicom.c: In function 'isicom_probe':
drivers/char/isicom.c:1793: warning: implicit declaration of function 'pci_request_region' drivers/char/isicom.c:1827: warning: implicit declaration of function 'pci_release_region'

---
 drivers/char/Kconfig |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/char/Kconfig +2 -2
@@ -203,7 +203,7 @@ config MOXA_SMARTIO
 
 config MOXA_SMARTIO_NEW
 	tristate "Moxa SmartIO support v. 2.0 (EXPERIMENTAL)"
-	depends on SERIAL_NONSTANDARD
+	depends on SERIAL_NONSTANDARD && PCI
 	help
 	  Say Y here if you have a Moxa SmartIO multiport serial card and/or
 	  want to help develop a new version of this driver.
@@ -218,7 +218,7 @@ config MOXA_SMARTIO_NEW
 
 config ISI
 	tristate "Multi-Tech multiport card support (EXPERIMENTAL)"
-	depends on SERIAL_NONSTANDARD
+	depends on SERIAL_NONSTANDARD && PCI
 	select FW_LOADER
 	help
 	  This is a driver for the Multi-Tech cards which provide several

drivers/char/Kconfig config SPECIALIX_RTSCTS · line 318

Quoted 8 lines
drivers/char/Kconfig +1 -1
@@ -312,7 +312,7 @@ config SPECIALIX_RTSCTS
 
 config SX
 	tristate "Specialix SX (and SI) card support"
-	depends on SERIAL_NONSTANDARD
+	depends on SERIAL_NONSTANDARD && PCI
 	help
 	  This is a driver for the SX and SI multiport serial cards.
 	  Please read the file <file:Documentation/sx.txt> for details.

Nack. I have to correct the mxser and sx code. Thanks,

Signature · 4 lines
http://www.fi.muni.cz/~xslaby/            Jiri Slaby
faculty of informatics, masaryk university, brno, cz
e-mail: jirislaby gmail com, gpg pubkey fingerprint:
B674 9967 0407 CE62 ACC8  22A0 32CC 55C3 39D4 7A7E
#2 lore raw
Quoted 41 lines · Jiri Slaby
Quoted 40 lines · Randy Dunlap

From: Randy Dunlap <[email protected]>

With CONFIG_PCI=n:
drivers/char/mxser_new.c: In function 'mxser_release_res':
drivers/char/mxser_new.c:2383: warning: implicit declaration of function 'pci_release_region' drivers/char/mxser_new.c: In function 'mxser_probe':
drivers/char/mxser_new.c:2578: warning: implicit declaration of function 'pci_request_region' drivers/built-in.o: In function `sx_remove_card':
sx.c:(.text.sx_remove_card+0x65): undefined reference to `pci_release_region' drivers/char/isicom.c: In function 'isicom_probe':
drivers/char/isicom.c:1793: warning: implicit declaration of function 'pci_request_region' drivers/char/isicom.c:1827: warning: implicit declaration of function 'pci_release_region'

---
 drivers/char/Kconfig |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/char/Kconfig +2 -2
@@ -203,7 +203,7 @@ config MOXA_SMARTIO
 
 config MOXA_SMARTIO_NEW
 	tristate "Moxa SmartIO support v. 2.0 (EXPERIMENTAL)"
-	depends on SERIAL_NONSTANDARD
+	depends on SERIAL_NONSTANDARD && PCI
 	help
 	  Say Y here if you have a Moxa SmartIO multiport serial card and/or
 	  want to help develop a new version of this driver.
@@ -218,7 +218,7 @@ config MOXA_SMARTIO_NEW
 
 config ISI
 	tristate "Multi-Tech multiport card support (EXPERIMENTAL)"
-	depends on SERIAL_NONSTANDARD
+	depends on SERIAL_NONSTANDARD && PCI
 	select FW_LOADER
 	help
 	  This is a driver for the Multi-Tech cards which provide several
@@ -312,7 +312,7 @@ config SPECIALIX_RTSCTS
 
Quoted 9 lines

drivers/char/Kconfig config SPECIALIX_RTSCTS · line 318

Quoted 7 lines
drivers/char/Kconfig +1 -1
 config SX
 	tristate "Specialix SX (and SI) card support"
-	depends on SERIAL_NONSTANDARD
+	depends on SERIAL_NONSTANDARD && PCI
 	help
 	  This is a driver for the SX and SI multiport serial cards.
 	  Please read the file <file:Documentation/sx.txt> for details.

Nack. I have to correct the mxser and sx code. Thanks,

Sure, either way is OK. Thanks.

Signature · 1 line
~Randy
#3 lore raw
Quoted 58 lines · Randy Dunlap
Quoted 47 lines · Jiri Slaby
Quoted 46 lines · Randy Dunlap

From: Randy Dunlap <[email protected]>

With CONFIG_PCI=n:
drivers/char/mxser_new.c: In function 'mxser_release_res':
drivers/char/mxser_new.c:2383: warning: implicit declaration of function 'pci_release_region'
drivers/char/mxser_new.c: In function 'mxser_probe':
drivers/char/mxser_new.c:2578: warning: implicit declaration of function 'pci_request_region'
drivers/built-in.o: In function `sx_remove_card':
sx.c:(.text.sx_remove_card+0x65): undefined reference to `pci_release_region'
drivers/char/isicom.c: In function 'isicom_probe':
drivers/char/isicom.c:1793: warning: implicit declaration of function 'pci_request_region'
drivers/char/isicom.c:1827: warning: implicit declaration of function 'pci_release_region'

---
 drivers/char/Kconfig |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/char/Kconfig +1 -1
@@ -203,7 +203,7 @@ config MOXA_SMARTIO
 
 config MOXA_SMARTIO_NEW
     tristate "Moxa SmartIO support v. 2.0 (EXPERIMENTAL)"
-    depends on SERIAL_NONSTANDARD
+    depends on SERIAL_NONSTANDARD && PCI
     help
       Say Y here if you have a Moxa SmartIO multiport serial card

and/or
want to help develop a new version of this driver.

drivers/char/Kconfig +1 -1
@@ -218,7 +218,7 @@ config MOXA_SMARTIO_NEW
 
 config ISI
     tristate "Multi-Tech multiport card support (EXPERIMENTAL)"
-    depends on SERIAL_NONSTANDARD
+    depends on SERIAL_NONSTANDARD && PCI
     select FW_LOADER
     help
       This is a driver for the Multi-Tech cards which provide several
@@ -312,7 +312,7 @@ config SPECIALIX_RTSCTS
 
Quoted 9 lines

drivers/char/Kconfig config SPECIALIX_RTSCTS · line 318

Quoted 7 lines
drivers/char/Kconfig +1 -1
 config SX
     tristate "Specialix SX (and SI) card support"
-    depends on SERIAL_NONSTANDARD
+    depends on SERIAL_NONSTANDARD && PCI
     help
       This is a driver for the SX and SI multiport serial cards.
       Please read the file <file:Documentation/sx.txt> for details.

Nack. I have to correct the mxser and sx code. Thanks,

Quoted 1 line

Sure, either way is OK. Thanks.

But those drivers support ISA devices too. Ok then, let "&& PCI" be as a correct temporary way and I'll add "|| ISA" after the proposed code fix :).

regards,

Signature · 4 lines
http://www.fi.muni.cz/~xslaby/            Jiri Slaby
faculty of informatics, masaryk university, brno, cz
e-mail: jirislaby gmail com, gpg pubkey fingerprint:
B674 9967 0407 CE62 ACC8  22A0 32CC 55C3 39D4 7A7E
#4 lore raw
Quoted 2 lines

But those drivers support ISA devices too. Ok then, let "&& PCI" be as a correct temporary way and I'll add "|| ISA" after the proposed code fix :).

That stops it being built on some platforms that have ISA and not PCI. Seems a poor fix for what really is a couple of ifdefs

#5 lore raw
Quoted 5 lines · Alan
Quoted 2 lines

But those drivers support ISA devices too. Ok then, let "&& PCI" be as a correct temporary way and I'll add "|| ISA" after the proposed code fix :).

That stops it being built on some platforms that have ISA and not PCI. Seems a poor fix for what really is a couple of ifdefs

They currently won't build for ISA because they always use the pci functions, so yes, they do need to be fixed (correctly) --> Jiri :)

Signature · 1 line
~Randy