Skip to contentSkip to conversation

proper prototype for remove_inode_dquot_ref()

PATCH In review Adrian Bunk 2 participants 2 messages Nov 29, 2006

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 proper prototype for remove_inode_dquot_ref()

This patch adds a proer prototype for remove_inode_dquot_ref() in include/linux/quotaops.h

---

 fs/inode.c               |    3 ---
 include/linux/quotaops.h |    3 +++
 2 files changed, 3 insertions(+), 3 deletions(-)
include/linux/quotaops.h renamed from include/linux/quotaops.h.old +3 -0
@@ -37,6 +37,9 @@
 extern int dquot_commit_info(struct super_block *sb, int type);
 extern int dquot_mark_dquot_dirty(struct dquot *dquot);
 
+int remove_inode_dquot_ref(struct inode *inode, int type,
+			   struct list_head *tofree_head);
+
 extern int vfs_quota_on(struct super_block *sb, int type, int format_id, char *path);
 extern int vfs_quota_on_mount(struct super_block *sb, char *qf_name,
 		int format_id, int type);
fs/inode.c renamed from fs/inode.c.old +0 -3
@@ -1249,9 +1249,6 @@
  */
 #ifdef CONFIG_QUOTA
 
-/* Function back in dquot.c */
-int remove_inode_dquot_ref(struct inode *, int, struct list_head *);
-
 void remove_dquot_ref(struct super_block *sb, int type,
 			struct list_head *tofree_head)
 {
reviewer
#1 lore raw
Quoted 4 lines

This patch adds a proer prototype for remove_inode_dquot_ref() in include/linux/quotaops.h

Fine with me, if you find it better this way (but that function is not
really supposed to be called from anywhere else).

Honza

Quoted 30 lines

---

 fs/inode.c               |    3 ---
 include/linux/quotaops.h |    3 +++
 2 files changed, 3 insertions(+), 3 deletions(-)
include/linux/quotaops.h renamed from include/linux/quotaops.h.old +3 -0
@@ -37,6 +37,9 @@
 extern int dquot_commit_info(struct super_block *sb, int type);
 extern int dquot_mark_dquot_dirty(struct dquot *dquot);
 
+int remove_inode_dquot_ref(struct inode *inode, int type,
+			   struct list_head *tofree_head);
+
 extern int vfs_quota_on(struct super_block *sb, int type, int format_id, char *path);
 extern int vfs_quota_on_mount(struct super_block *sb, char *qf_name,
 		int format_id, int type);
fs/inode.c renamed from fs/inode.c.old +0 -3
@@ -1249,9 +1249,6 @@
  */
 #ifdef CONFIG_QUOTA
 
-/* Function back in dquot.c */
-int remove_inode_dquot_ref(struct inode *, int, struct list_head *);
-
 void remove_dquot_ref(struct super_block *sb, int type,
 			struct list_head *tofree_head)
 {
Signature · 2 lines
Jan Kara <[email protected]>
SuSE CR Labs