Skip to contentSkip to conversation

arch/parisc/Makefile: remove GCC_VERSION

PATCH In review Adrian Bunk 3 participants 5 messages Dec 1, 2006 – Dec 8, 2006 PA-RISC architecture

lore
Share & tools
lore

Adrian Bunk

author
#0 lore raw

PATCH 1/1 arch/parisc/Makefile: remove GCC_VERSION

This patch removes the usage of GCC_VERSION from arch/parisc/Makefile.

There are no functional changes, it simply makes it a bit shorter (and removes the last instance of GCC_VERSION in the kernel).

Signed-off-by Adrian Bunk <[email protected]>
Acked-by Kyle McMartin <[email protected]>

---

This patch was already sent on:
- 21 Nov 2006
- 19 Aug 2006
- 12 Jan 2006

arch/parisc/Makefile renamed from arch/parisc/Makefile.old +2 -6
@@ -35,12 +35,8 @@
 
 OBJCOPY_FLAGS =-O binary -R .note -R .comment -S
 
-GCC_VERSION     := $(call cc-version)
-ifneq ($(shell if [ -z $(GCC_VERSION) ] ; then echo "bad"; fi ;),)
-$(error Sorry, couldn't find ($(cc-version)).)
-endif
-ifneq ($(shell if [ $(GCC_VERSION) -lt 0303 ] ; then echo "bad"; fi ;),)
-$(error Sorry, your compiler is too old ($(GCC_VERSION)).  GCC v3.3 or above is required.)
+ifneq ($(shell if [ $(call cc-version) -lt 0303 ] ; then echo "bad"; fi ;),)
+$(error Sorry, your compiler is too old.  GCC v3.3 or above is required.)
 endif
 
 cflags-y	:= -pipe
#1 lore raw
Quoted 4 lines · Adrian Bunk

This patch removes the usage of GCC_VERSION from arch/parisc/Makefile.

There are no functional changes, it simply makes it a bit shorter (and removes the last instance of GCC_VERSION in the kernel).

Thanks!
I've committed a variant of this to git://git.parisc-linux.org/git/linux-2.6.git
I didn't test the failure case - only that it doesn't trigger with my current gcc 4.x compilers.

I expect Kyle will push parisc tree to linus in the near future.

Signed-off-by Grant Grundler <[email protected]>
arch/parisc/Makefile +2 -6
index 9b7e424..760567a 100644
@@ -35,12 +35,8 @@ FINAL_LD=$(CROSS_COMPILE)ld --warn-commo
 
 OBJCOPY_FLAGS =-O binary -R .note -R .comment -S
 
-GCC_VERSION     := $(call cc-version)
-ifneq ($(shell if [ -z $(GCC_VERSION) ] ; then echo "bad"; fi ;),)
-$(error Sorry, couldn't find ($(cc-version)).)
-endif
-ifneq ($(shell if [ $(GCC_VERSION) -lt 0303 ] ; then echo "bad"; fi ;),)
-$(error Sorry, your compiler is too old ($(GCC_VERSION)).  GCC v3.3 or above is required.)
+ifneq ($(call cc-ifversion, -lt, 0303, "bad"),)
+$(error Sorry, GCC v3.3 or above is required.)
 endif
 
 cflags-y	:= -pipe

_______________________________________________
parisc-linux mailing list
[email protected]
http://lists.parisc-linux.org/mailman/listinfo/parisc-linux

#2 lore raw
In reply to Adrian Bunk
Quoted 4 lines · Adrian Bunk

This patch removes the usage of GCC_VERSION from arch/parisc/Makefile.

There are no functional changes, it simply makes it a bit shorter (and removes the last instance of GCC_VERSION in the kernel).

Thanks!
I've committed a variant of this to git://git.parisc-linux.org/git/linux-2.6.git
I didn't test the failure case - only that it doesn't trigger with my current gcc 4.x compilers.

I expect Kyle will push parisc tree to linus in the near future.

Signed-off-by Grant Grundler <[email protected]>
arch/parisc/Makefile +2 -6
index 9b7e424..760567a 100644
@@ -35,12 +35,8 @@ FINAL_LD=$(CROSS_COMPILE)ld --warn-commo
 
 OBJCOPY_FLAGS =-O binary -R .note -R .comment -S
 
-GCC_VERSION     := $(call cc-version)
-ifneq ($(shell if [ -z $(GCC_VERSION) ] ; then echo "bad"; fi ;),)
-$(error Sorry, couldn't find ($(cc-version)).)
-endif
-ifneq ($(shell if [ $(GCC_VERSION) -lt 0303 ] ; then echo "bad"; fi ;),)
-$(error Sorry, your compiler is too old ($(GCC_VERSION)).  GCC v3.3 or above is required.)
+ifneq ($(call cc-ifversion, -lt, 0303, "bad"),)
+$(error Sorry, GCC v3.3 or above is required.)
 endif
 
 cflags-y	:= -pipe
#3 lore raw
Quoted 8 lines · Grant Grundler

I've committed a variant of this to git://git.parisc-linux.org/git/linux-2.6.git
I didn't test the failure case - only that it doesn't trigger with my current gcc 4.x compilers.

I expect Kyle will push parisc tree to linus in the near future.

Signed-off-by Grant Grundler <[email protected]>

I like the version ggg committed to our cvs better (and I verified it correctly functions with gcc-3.0 from Debian woody.)

Picked into my tree.

Cheers,
Kyle
_______________________________________________
parisc-linux mailing list
[email protected]
http://lists.parisc-linux.org/mailman/listinfo/parisc-linux

#4 lore raw
In reply to Grant Grundler
Quoted 8 lines · Grant Grundler

I've committed a variant of this to git://git.parisc-linux.org/git/linux-2.6.git
I didn't test the failure case - only that it doesn't trigger with my current gcc 4.x compilers.

I expect Kyle will push parisc tree to linus in the near future.

Signed-off-by Grant Grundler <[email protected]>

I like the version ggg committed to our cvs better (and I verified it correctly functions with gcc-3.0 from Debian woody.)

Picked into my tree.

Cheers,
Kyle