Skip to contentSkip to conversation

Fix for sunhme failures on x86

PATCH In review Jurij Smakov 2 participants 2 messages Dec 3, 2006 Network drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fix for sunhme failures on x86

Hi,

The following patch fixes the failure of sunhme drivers on x86 hosts due to missing pci_enable_device() and pci_set_master() calls, lost during code refactoring. It has been filed as bugzilla bug #7502 [0] and Debian bug #397460 [1].

[0] http://bugzilla.kernel.org/show_bug.cgi?idu02
[1] http://bugs.debian.org/397460

drivers/net/sunhme.c +5 -0
diff -aur a/drivers/net/sunhme.c b/drivers/net/sunhme.c
@@ -3012,6 +3012,11 @@
 #endif
 
 	err = -ENODEV;
+
+	if (pci_enable_device(pdev))
+		goto err_out;
+	pci_set_master(pdev);
+
 	if (!strcmp(prom_name, "SUNW,qfe") || !strcmp(prom_name, "qfe")) {
 		qp = quattro_pci_find(pdev);
 		if (qp = NULL)
Signature · 2 lines
Jurij Smakov                                           [email protected]
Key: http://www.wooyd.org/pgpkey/                      KeyID: C99E03CC
maintainer
#1 lore raw

From: Jurij Smakov <[email protected]>
Date: Sun, 3 Dec 2006 13:55:22 -0800

Quoted 11 lines

Hi,

The following patch fixes the failure of sunhme drivers on x86 hosts due to missing pci_enable_device() and pci_set_master() calls, lost during code refactoring. It has been filed as bugzilla bug #7502 [0] and Debian bug #397460 [1].

[0] http://bugzilla.kernel.org/show_bug.cgi?idu02
[1] http://bugs.debian.org/397460

Thanks a lot for figuring this out Jurij, I'll apply this and push to -stable later tonight.