git-sas Kconfig fix

PATCH New [email protected] 1 participant 1 message Dec 4, 2006

Subsystems (2)

SCSI SCSI libsas

lore

Share & tools

lore

[email protected]

author

2006-12-04 23:22 UTC #0 lore raw

PATCH 1/2 git-sas Kconfig fix

From: "Darrick J. Wong" <[email protected]>

Quoted 7 lines · Andrew Morton

WARNING: "ata_sas_slave_configure" [drivers/scsi/libsas/libsas.ko] undefined!
WARNING: "ata_port_disable" [drivers/scsi/libsas/libsas.ko] undefined!
WARNING: "ata_sas_port_init" [drivers/scsi/libsas/libsas.ko] undefined!
WARNING: "ata_sas_port_stop" [drivers/scsi/libsas/libsas.ko] undefined!
WARNING: "ata_sas_port_start" [drivers/scsi/libsas/libsas.ko] undefined!
WARNING: "ata_sas_port_alloc" [drivers/scsi/libsas/libsas.ko] undefined!
WARNING: "ata_noop_qc_prep" [drivers/scsi/libsas/libsas.ko] undefined!

Quoted 8 lines

WARNING: "ata_tf_to_fis" [drivers/scsi/libsas/libsas.ko] undefined!
WARNING: "ata_noop_dev_select" [drivers/scsi/libsas/libsas.ko] undefined!
WARNING: "ata_tf_from_fis" [drivers/scsi/libsas/libsas.ko] undefined!
WARNING: "ata_host_init" [drivers/scsi/libsas/libsas.ko] undefined!
WARNING: "ata_sas_queuecmd" [drivers/scsi/libsas/libsas.ko] undefined!
WARNING: "ata_sas_port_destroy" [drivers/scsi/libsas/libsas.ko] undefined!
WARNING: "ata_scsi_ioctl" [drivers/scsi/libsas/libsas.ko] undefined!
WARNING: "ata_qc_complete" [drivers/scsi/libsas/libsas.ko] undefined!

The SATA-fortified libsas depends on libata for SATA support. Kconfig needs to know about that. Patch is for aic94xx-sas-2.6 and apparently -mm as well.

Signed-off-by Darrick J. Wong <[email protected]>

Cc James Bottomley <[email protected]>

Signed-off-by Andrew Morton <[email protected]>

---

 drivers/scsi/libsas/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/scsi/libsas/Kconfig renamed from drivers/scsi/libsas/Kconfig~git-sas-kconfig-fix +1 -1

diff -puN drivers/scsi/libsas/Kconfig~git-sas-kconfig-fix drivers/scsi/libsas/Kconfig
@@ -24,7 +24,7 @@
 
 config SCSI_SAS_LIBSAS
 	tristate "SAS Domain Transport Attributes"
-	depends on SCSI
+	depends on SCSI && ATA
 	select SCSI_SAS_ATTRS
 	help
 	  This provides transport specific helpers for SAS drivers which