Skip to contentSkip to conversation

WorkStruct: Fix spi_bitbang.h

PATCH In review David Howells 3 participants 5 messages Dec 7, 2006 SPI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 WorkStruct: Fix spi_bitbang.h

Fix spi_bitbang.h. It need to #include <linux/workqueue.h> before it can compile.

---

 include/linux/spi/spi_bitbang.h |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
include/linux/spi/spi_bitbang.h +2 -0
index 16ce178..33fa727 100644
@@ -1,6 +1,8 @@
 #ifndef	__SPI_BITBANG_H
 #define	__SPI_BITBANG_H
 
+#include <linux/workqueue.h>
+
 /*
  * Mix this utility code with some glue code to get one of several types of
  * simple SPI master driver.  Two do polled word-at-a-time I/O:
#1 lore raw
Quoted 4 lines · David Howells

Fix spi_bitbang.h. It need to #include <linux/workqueue.h> before it can compile.

NAK. Headers don't compile. A driver including this _might_ need to include that header; most won't.

Quoted 20 lines

---

 include/linux/spi/spi_bitbang.h |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
include/linux/spi/spi_bitbang.h +2 -0
index 16ce178..33fa727 100644
@@ -1,6 +1,8 @@
 #ifndef	__SPI_BITBANG_H
 #define	__SPI_BITBANG_H
 
+#include <linux/workqueue.h>
+
 /*
  * Mix this utility code with some glue code to get one of several types of
  * simple SPI master driver.  Two do polled word-at-a-time I/O:
#2 lore raw
Quoted 2 lines · David Brownell

NAK. Headers don't compile. A driver including this _might_ need to include that header; most won't.

Please be more specific. It compiles for myself and for Ben. I used the s3c2410_defconfig configuration. It won't compile without it.

David

#3 lore raw
Quoted 8 lines · On Thu, 07 Dec 2006 15:37:35 +0000 David Howells <[email protected]> wrote:
Quoted 2 lines · David Brownell

NAK. Headers don't compile. A driver including this _might_ need to include that header; most won't.

Please be more specific. It compiles for myself and for Ben. I used the s3c2410_defconfig configuration. It won't compile without it.

It's a simple matter to quote the gcc stderr in the patch's changelog and it is often very useful.

#4 lore raw
In reply to David Howells
Quoted 7 lines · David Howells
Quoted 2 lines · David Brownell

NAK. Headers don't compile. A driver including this _might_ need to include that header; most won't.

Please be more specific. It compiles for myself and for Ben. I used the s3c2410_defconfig configuration. It won't compile without it.

So tell me, what part of the kernel build tries to compile a header file all by itself? What object file does it become? And where is that object module installed?

Now, if you have an example of some _C_ file that's needs some help compiling, that would be interesting ... and indicative of the right place to change.