Skip to contentSkip to conversation

Remove useless wmb() memory barrier

PATCH New Ralf Baechle 1 participant 1 message Dec 8, 2006 XFS filesystem

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Remove useless wmb() memory barrier

wake_up's implementation does an implicit memory barrier and I think that's the only sane semantics as the caller shouldn't have to worry. So this write memory barrier is useless.

fs/xfs/linux-2.6/xfs_super.c +0 -1
index b93265b..33800c7 100644
@@ -553,7 +553,6 @@ vfs_sync_worker(
 		error = bhv_vfs_sync(vfsp, SYNC_FSDATA | SYNC_BDFLUSH | \
 					SYNC_ATTR | SYNC_REFCACHE, NULL);
 	vfsp->vfs_sync_seq++;
-	wmb();
 	wake_up(&vfsp->vfs_wait_single_sync_task);
 }