Skip to contentSkip to conversation

tty_io.c balance tty_ldisc_ref()

PATCH In review dcarpenter 2 participants 2 messages Dec 10, 2006 Char and misc drivers

lore
Share & tools
lore

dcarpenter

author
#0 lore raw

PATCH 1/1 tty_io.c balance tty_ldisc_ref()

tty_ldisc_deref() should only be called when tty_ldisc_ref() succeeds otherwise it triggers a BUG(). There's already a function tty_ldisc_flush() that flushes properly.

drivers/char/tty_io.c +1 -6
index 4044c86..bf6699b 100644
@@ -3335,18 +3335,13 @@ #else
 	int session;
 	int		i;
 	struct file	*filp;
-	struct tty_ldisc *disc;
 	struct fdtable *fdt;
 	
 	if (!tty)
 		return;
 	session = tty->session;
 	
-	/* We don't want an ldisc switch during this */
-	disc = tty_ldisc_ref(tty);
-	if (disc && disc->flush_buffer)
-		disc->flush_buffer(tty);
-	tty_ldisc_deref(disc);
+	tty_ldisc_flush(tty);
 
 	if (tty->driver->flush_buffer)
 		tty->driver->flush_buffer(tty);