Skip to contentSkip to conversation

cio: css_register_subchannel race.

S390 Martin Schwidefsky 1 participant 1 message Dec 15, 2006

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

From: Stefan Bader <[email protected]>

[S390] cio: css_register_subchannel race.

Asynchronous probe can release memory of a subchannel before css_get_ssd_info is called. To fix this call css_get_ssd_info before registering with driver core.

---

 drivers/s390/cio/css.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletion(-)
drivers/s390/cio/css.c +2 -1
diff -urpN linux-2.6/drivers/s390/cio/css.c linux-2.6-patched/drivers/s390/cio/css.c
@@ -139,6 +139,8 @@ css_register_subchannel(struct subchanne
 	sch->dev.release = &css_subchannel_release;
 	sch->dev.groups = subch_attr_groups;
 
+	css_get_ssd_info(sch);
+
 	/* make it known to the system */
 	ret = css_sch_device_register(sch);
 	if (ret) {
@@ -146,7 +148,6 @@ css_register_subchannel(struct subchanne
 			__func__, sch->dev.bus_id);
 		return ret;
 	}
-	css_get_ssd_info(sch);
 	return ret;
 }