Skip to contentSkip to conversation

tlclk: delete unnecessary sysfs_remove_group

PATCH New Akinobu Mita 1 participant 1 message Dec 19, 2006

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tlclk: delete unnecessary sysfs_remove_group

It is unnecessary and invalid to call sysfs_remove_group() after sysfs_create_group() failure.

Cc Sebastien Bouchard <[email protected]>
Cc Mark Gross <[email protected]>
---
 drivers/char/tlclk.c |    2 --
 1 file changed, 2 deletions(-)
drivers/char/tlclk.c +0 -2
Index: 2.6-mm/drivers/char/tlclk.c
===================================================================
@@ -807,8 +807,6 @@ static int __init tlclk_init(void)
 			&tlclk_attribute_group);
 	if (ret) {
 		printk(KERN_ERR "tlclk: failed to create sysfs device attributes.\n");
-		sysfs_remove_group(&tlclk_device->dev.kobj,
-			&tlclk_attribute_group);
 		goto out5;
 	}