Skip to contentSkip to conversation

Return failure error if something fails in xfs_growfs

PATCH In review Barry Naujok 3 participants 3 messages Dec 21, 2006

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Return failure error if something fails in xfs_growfs

A very simple patch that return error rather than success if something fails in xfs_growfs.

Barry.

xfsprogs/growfs/xfs_growfs.c +1 -1
@@ -448,5 +448,5 @@
 	if (geo.rtextsize != ngeo.rtextsize)
 		printf(_("realtime extent size changed from %d to %d\n"),
 			geo.rtextsize, ngeo.rtextsize);
-	exit(0);
+	exit(error);
 }
#1 lore raw
Quoted 1 line · Barry Naujok

...

Makes sense & looks correct in xdiff. :)

cheers.

Signature · 1 line
Nathan
#2 lore raw
In reply to Barry Naujok
Quoted 4 lines · Barry Naujok

A very simple patch that return error rather than success if something fails in xfs_growfs.

Barry.

Try as I might to follow the grand linux tradition of finding some minor stylistic point to complain about (whitespace, formatting, choice of variable names, etc) I could not. So, looks good to me. :-)

-Eric