Skip to contentSkip to conversation

: Workqueue changes for board-h3

PATCH In review Ragner N Magalhães 2 participants 2 messages Dec 28, 2006 1 message not in the archive

Subsystems (3)
lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

PATCH 1/1 : Workqueue changes for board-h3

---------- Forwarded message ----------
From: Felipe Balbi <[email protected]>
Date: Dec 28, 2006 9:28 AM
Subject: [PATCH]: Workqueue changes for board-h3
To: [email protected]

Hello all,

This patch fixes an error regarding workqueue changes on board-h3 file.]

=================== CUT HERE ==========================
Fixes a compile issue when using CONFIG_MACH_OMAP_H3 regarding workqueues.

---

arch/arm/mach-omap1/board-h3.c +1 -1
Index: linux-omap-2.6-dev/arch/arm/mach-omap1/board-h3.c
===================================================================
@@ -298,5 +298,5 @@ static int h3_select_irda(struct device
 
-static void set_trans_mode(void *data)
+static void set_trans_mode(struct work_struct *data)

{
- int *mode = data;

+	int *mode = (int *)data;
	unsigned char expa;

@@ -321,3 +321,3 @@ static void set_trans_mode(void *data)

-static int h3_transceiver_mode(struct device *dev, int mode)
+static int h3_transceiver_mode(struct device *dev) {
@@ -326,4 +326,3 @@ static int h3_transceiver_mode(struct de

	cancel_delayed_work(&irda_config->gpio_expa);
-	PREPARE_WORK(&irda_config->gpio_expa, set_trans_mode, &mode);
-#error this is not permitted - mode is an argument variable
+	PREPARE_WORK(&(irda_config->gpio_expa.work), set_trans_mode);
	schedule_delayed_work(&irda_config->gpio_expa, 0);
include/asm-arm/arch-omap/irda.h +0 -0
Index: linux-omap-2.6-dev/include/asm-arm/arch-omap/irda.h
===================================================================
@@ -21,3 +21,3 @@ struct omap_irda_config {
	int transceiver_cap;
-	int (*transceiver_mode)(struct device *dev, int mode);
+	int (*transceiver_mode)(struct device *dev);
	int (*select_irda)(struct device *dev, int state);

Best Regards,

Felipe Balbi
[email protected]

Nokia Institute of Technology - INdT
Kernel Developers Team

+55 92 8127 0839

#2 lore raw
Quoted 24 lines · Ragner N Magalhães

---------- Forwarded message ----------
From: Felipe Balbi <[email protected]>
Date: Dec 28, 2006 9:28 AM
Subject: [PATCH]: Workqueue changes for board-h3
To: [email protected]

Hello all,

This patch fixes an error regarding workqueue changes on board-h3 file.]

=================== CUT HERE ==========================
Fixes a compile issue when using CONFIG_MACH_OMAP_H3 regarding workqueues.

---

Index: linux-omap-2.6-dev/arch/arm/mach-omap1/board-h3.c
===================================================================

arch/arm/mach-omap1/board-h3.c static int h3_select_irda(struct device · line 301

Quoted 6 lines
arch/arm/mach-omap1/board-h3.c +2 -2
@@ -298,5 +298,5 @@ static int h3_select_irda(struct device
 
-static void set_trans_mode(void *data)
+static void set_trans_mode(struct work_struct *data)
 {
-       int *mode = data;
+       int *mode = (int *)data;

Did you tested this patch.? I am not sure this casting is the correct way to go for it.

Signature · 2 lines
---Komal Shah
http://komalshah.blogspot.com