the scheduled find_trylock_page() removal
Subsystems (3)
PATCH 1/1 the scheduled find_trylock_page() removal
This patch contains the scheduled find_trylock_page() removal.
---
Documentation/feature-removal-schedule.txt | 12 ------------ include/linux/pagemap.h | 2 -- mm/filemap.c | 20 -------------------- 3 files changed, 34 deletions(-)
Documentation/feature-removal-schedule.txt renamed from Documentation/feature-removal-schedule.txt.old +0 -12
@@ -163,18 +163,6 @@ --------------------------- -What: find_trylock_page -When: January 2007 -Why: The interface no longer has any callers left in the kernel. It - is an odd interface (compared with other find_*_page functions), in - that it does not take a refcount to the page, only the page lock. - It should be replaced with find_get_page or find_lock_page if possible. - This feature removal can be reevaluated if users of the interface - cannot cleanly use something else. -Who: Nick Piggin <[email protected]> - ---------------------------- - What: Interrupt only SA_* flags When: Januar 2007 Why: The interrupt related SA_* flags are replaced by IRQF_* to move them
include/linux/pagemap.h renamed from include/linux/pagemap.h.old +0 -2
@@ -78,8 +78,6 @@ unsigned long index);extern struct page *find_lock_page (struct address_space *mapping,unsigned long index); -extern __deprecated_for_modules struct page * find_trylock_page( -struct address_space *mapping,unsigned long index);extern struct page *find_or_create_page (struct address_space *mapping,unsigned long index,gfp_t gfp_mask); unsigned find_get_pages(struct address_space *mapping, pgoff_t start,
mm/filemap.c renamed from mm/filemap.c.old +0 -20
@@ -630,26 +630,6 @@EXPORT_SYMBOL (find_get_page);/** -* find_trylock_page - find and lock a page -* @mapping: the address_space to search -* @offset: the page index -* -* Same as find_get_page(), but trylock it instead of incrementing the count. -*/ -struct page *find_trylock_page (struct address_space *mapping,unsigned long offset) -{ -struct page *page; - -read_lock_irq (&mapping->tree_lock); - page =radix_tree_lookup (&mapping->page_tree, offset); -if (page &&TestSetPageLocked (page)) - page =NULL ; -read_unlock_irq (&mapping->tree_lock); -return page; -} -EXPORT_SYMBOL (find_trylock_page); - -/** * find_lock_page - locate, pin and lock a pagecache page * @mapping: the address_space to search * @offset: the page index
Quoted 3 lines · Adrian Bunk
This patch contains the scheduled
find_trylock_page()removal.Signed-off-by Adrian Bunk <[email protected]>
I guess I don't have a problem with this going into -mm and making its way upstream sometime after the next release.
I would normally say it is OK to stay for another year because it is so unintrusive, but I don't like the fact it doesn't give one an explicit ref on the page -- it could be misused slightly more easily than find_lock_page or find_get_page.
Anyone object? Otherwise:
Signature · 8 lines
SUSE Labs, Novell Inc. Send instant messages to your online friends http://au.messenger.yahoo.com -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Quoted 8 lines · Nick Piggin
Quoted 3 lines · Adrian Bunk
This patch contains the scheduled
find_trylock_page()removal.Signed-off-by Adrian Bunk <[email protected]>I guess I don't have a problem with this going into -mm and making its way upstream sometime after the next release.
Quoted 6 lines
I would normally say it is OK to stay for another year because it is so unintrusive, but I don't like the fact it doesn't give one an explicit ref on the page -- it could be misused slightly more easily than
find_lock_pageorfind_get_page.Anyone object? Otherwise:
Just kill it. There's absolutely no point in keeping dead code around. It's bad enough we keep such things around for half a year.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>