Skip to contentSkip to conversation

make initkmem_list3 non init data to fix modpost warning

PATCH In review Vivek Goyal 2 participants 2 messages Jan 8, 2007 Memory management

lore
Share & tools
lore
#0 lore raw

PATCH 2/4 make initkmem_list3 non init data to fix modpost warning

o MODPOST generates warning for i386 if kernel is compiled with CONFIG_RELOCATABLE=y

WARNING: vmlinux - Section mismatch: reference to .init.data:initkmem_list3 from .text between 'set_up_list3s' (at offset 0xc01536d9) and 's_start'

o I don't know the code well but looks like this is a bug. initkmem_list3 is of type __initdata, and it is accessed by non init functions.

	kmem_cache_create()
		setup_cpu_cache()
			set_up_list3s()
				{
					Accesses initkmem_list3[]
				}

o Somebody who knows this code well needs to review and ack.

---

 mm/slab.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
mm/slab.c renamed from mm/slab.c~make-initkmem_list3-non-init +1 -1
diff -puN mm/slab.c~make-initkmem_list3-non-init mm/slab.c
@@ -305,7 +305,7 @@ struct kmem_list3 {
  * Need this for bootstrapping a per node allocator.
  */
 #define NUM_INIT_LISTS (2 * MAX_NUMNODES + 1)
-struct kmem_list3 __initdata initkmem_list3[NUM_INIT_LISTS];
+struct kmem_list3 initkmem_list3[NUM_INIT_LISTS];
 #define	CACHE_CACHE 0
 #define	SIZE_AC 1
 #define	SIZE_L3 (1 + MAX_NUMNODES)

_

#1 lore raw
Quoted 1 line · On Mon, 8 Jan 2007 13:41:04 +0530 Vivek Goyal <[email protected]> wrote:

o Somebody who knows this code well needs to review and ack.

eh. Moving stuff from __initdata into .data is always safe. If it fixes the warning, it's correct ;)

I'll scoot all four of these into 2.6.20, thanks.