What is in bcm43xx-wireless-dev.git?
Subsystems (2)
In case you wonder what's the future of bcm43xx, here's a list of changes in my bcm43xx development tree:
bcm43xx-d80211: Add some PHY register definitions.
bcm43xx-d80211: Move ILT stuff to OFDM table stuff
bcm43xx-d80211: Remove PHY OFDM routing bit, if we are on A-PHY.
bcm43xx-d80211: Merge new LO-control code.
bcm43xx-d80211: Fix compilation: Missing files for LO and VSTACK.
bcm43xx-d80211: Rename struct bcm43xx_phyinfo to struct bcm43xx_phy
bcm43xx-d80211: merge struct bcm43xx_radioinfo into struct bcm43xx_phy
bcm43xx-d80211: Merge all "radio" stuff into phy.c
bcm43xx-d80211: Fix antenna selection for TX and RX.
bcm43xx-d80211: Fix bogus LO validation failure.
bcm43xx-d80211: Remove netpoll and ethtool stuff.
Remove obsolete SSB driver library.
Implement new SSB subsystem.
bcm43xx-d80211: Port driver to the new SSB subsystem.
Well, that doesn't tell you anything, right?
Let's explain it:
Most significant changes are the new "LO" code and the completely rewritten "SSB" subsystem.
The LO calibration code is not yet finished and contains a few bugs, so it works _worse_ that the LO calibration code that's in mainline kernel. But it's the first step in the direction to support hwpctl cards (4318).
The other major change is the new SSB subsystem. This is a big step in the embedded direction. The new SSB subsystem makes it possible to run an (almost) vanilla (vanilla, as in my tree, which is supposed to get merged upstream some time :)) kernel on broadcom MIPS based embedded WLAN routers (openWRT).
bcm43xx works on the new subsystem. A working b44 port is available, but not included here. We might probably want to merge that through jeff directly once this is upstream. The SSB subsystem is able to boot my Linksys WRT54G. Wireless and LAN with SSB based chips basically works.
So, what to do?
Next think will be to fix the LO code to make it ready for upstream merge. I don't know if that means "making 4318 usable", too. Hopefully it does. Let's see. ;)
If you want to test this, get it from my repository. If you have a linville-wireless-dev tree around, please _don't_ clone my tree, but simply pull my stuff into a seperate branch of that tree:
git branch crazy_stuff
git checkout crazy_stuff
git pull http://bu3sch.de/git/wireless-dev.git master
That will save lots of bandwidth. (Yours and mine) Thanks! ;)
Here's also a bzipped patch between today's linville-wireless-dev and my tree. Yeah, it's huge, so not attached. :)
http://bu3sch.de/misc/linville_to_buesch_20070111.patch.bz2
Signature · 1 line
Greetings Michael.
Hello, Michael!
I've tried the master branch of bcm43xx-wireless-dev.git for the first time. The results are not encouraging so far (although I'm quite new to this chipset).
drivers/ssb/driver_mips/mips.c includes asm/time.h, which is missing on x86_64. It also refers to struct ssb_serial_ports, which is not defined anywhere.
drivers/ssb/driver_pci/pcicore.c refers to SSB_PCICORE_SBTOPCI1_CFG1 that is not defined anywhere in the kernel.
I could send you huge logs, but I think it's already a clear sign that you didn't compile-test the current tree with CONFIG_SSB_DRIVER_MIPS enabled. Things are better if it is disabled.
In case you haven't seen those warnings:
/home/proski/src/linux-2.6/drivers/net/wireless/d80211/bcm43xx/bcm43xx_main.c:843: warning: 'bcm43xx_wireless_core_mark_inactive' defined but not used /home/proski/src/linux-2.6/drivers/net/wireless/d80211/bcm43xx/bcm43xx_main.c:3032: warning: 'bcm43xx_bluetooth_coext_enable' defined but not used
I could compile the code, and it even loaded as a module, but the kernel oopsed once I brought wlan0 up by ifconfig.
bcm43xx_d80211: Adding Interface type 2bcm43xx_d80211: Found PHY: Version 4, Type 2, Revision 8bcm43xx_d80211: Found Radio: Manuf 0x17F, Version 0x2050, Revision 2bcm43xx_d80211: Loading firmware version 351.126 (2006-07-29 05:54:02)bcm43xx_d80211: Radio turned onbcm43xx_d80211: FIXME: Possibly broken code in bcm43xx_phy_initg() at /home/proski/src/linux-2.6/drivers/net/wireless/d80211/bcm43xx/bcm43xx_phy.c:1650bcm43xx_d80211: Chip initialized
Unable to handle kernel NULL pointer dereference at 0000000000000000 RIP: [<ffffffff8021eee6>] dma_alloc_coherent+0x52/0x23f PGD 50d1067 PUD 5201067 PMD 0 Oops: 0000 [1] SMP CPU 1 Modules linked in: bcm43xx_d80211 ssb Pid: 2623, comm: ifconfig Not tainted 2.6.20-rc3 #5 RIP: 0010:[<ffffffff8021eee6>] [<ffffffff8021eee6>] dma_alloc_coherent+0x52/0x23f RSP: 0018:ffff810005127bd8 EFLAGS: 00010206 RAX: 0000000000000000 RBX: 0000000000003500 RCX: 00000000000010d4 RDX: 00000000ffffffff RSI: 0000000000001000 RDI: ffff81000196c3a8 RBP: 00000000000010d0 R08: ffff81001f6d1600 R09: 0000000000000004 R10: 0000000000000001 R11: ffff810001122c60 R12: 0000000000001000 R13: ffff810001b96000 R14: ffff81000196c3a8 R15: 00000000ffffffff FS: 00002b411b2133b0(0000) GS:ffff810001827440(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 000000008005003b CR2: 0000000000000000 CR3: 0000000015fdf000 CR4: 00000000000006e0 Process ifconfig (pid: 2623, threadinfo ffff810005126000, task ffff81001f58d180) Stack: ffff81001ee6a3c0 ffff81001ee6a3e8 ffff810001b96000 0000000000003500 ffff81001ee6a3c0 0000000000000080 ffff810001b96000 0000000000000000 0000000000000000 ffffffff88019966 0000000000000005 0000000100000036 Call Trace: [<ffffffff88019966>] :bcm43xx_d80211:bcm43xx_setup_dmaring+0x1a7/0x460 [<ffffffff88019ea3>] :bcm43xx_d80211:bcm43xx_dma_init+0xc0/0x290 [<ffffffff88008131>] :bcm43xx_d80211:bcm43xx_wireless_core_init+0x78f/0x9f1 [<ffffffff8022885e>] mntput_no_expire+0x19/0x77 [<ffffffff8020a3c3>] do_page_fault+0x40b/0x74a [<ffffffff88009f4e>] :bcm43xx_d80211:bcm43xx_add_interface+0x67/0xeb [<ffffffff804378d2>] ieee80211_open+0x1c6/0x2c5 [<ffffffff803fd3ec>] dev_open+0x2f/0x6e [<ffffffff803fbcd5>] dev_change_flags+0x5a/0x119 [<ffffffff80423bab>] devinet_ioctl+0x235/0x59c [<ffffffff803f4bef>] sock_ioctl+0x1c8/0x1e5 [<ffffffff8023b862>] do_ioctl+0x21/0x6b [<ffffffff8022b614>] vfs_ioctl+0x25c/0x275 [<ffffffff8024559b>] sys_ioctl+0x3c/0x5c [<ffffffff802548ee>] system_call+0x7e/0x83 Code: 4c 23 38 49 39 d7 0f 46 e9 49 8d 44 24 ff 83 ca ff 49 89 c5 RIP [<ffffffff8021eee6>] dma_alloc_coherent+0x52/0x23f RSP <ffff810005127bd8>
CR2: 0000000000000000
It's Fedora Core 6 x86_64 on a Dell Latitude with Core 2 Duo and an PCIe wireless card. SMP is enabled. From .config:
CONFIG_BCM43XX_D80211=mCONFIG_BCM43XX_D80211_PCI=yCONFIG_BCM43XX_D80211_DEBUG=yCONFIG_BCM43XX_D80211_DMA=yCONFIG_BCM43XX_D80211_PIO=yCONFIG_BCM43XX_D80211_DMA_AND_PIO_MODE=y
# CONFIG_BCM43XX_D80211_DMA_MODE is not set
# CONFIG_BCM43XX_D80211_PIO_MODE is not set
[skip]CONFIG_SSB=m
# CONFIG_SSB_SILENT is not set
# CONFIG_SSB_DEBUG is not setCONFIG_SSB_DRIVER_EXTIF=y
# CONFIG_SSB_DRIVER_MIPS is not set
[root@localhost proski]# lspci -v -s 0c:00.0
0c:00.0 Network controller: Broadcom Corporation BCM4310 UART (rev 01)
Subsystem: Dell Unknown device 0007
Flags: bus master, fast devsel, latency 0, IRQ 17
Memory at efdfc000 (32-bit, non-prefetchable) [size=16K]
Capabilities: [40] Power Management version 2
Capabilities: [58] Message Signalled Interrupts: 64bit- Queue=0/0 Enable-
Capabilities: [d0] Express Legacy Endpoint IRQ 0
Capabilities: [100] Advanced Error Reporting
Capabilities: [13c] Virtual Channel
[root@localhost proski]# lspci -n -s 0c:00.0
0c:00.0 0280: 14e4:4312 (rev 01)
[root@localhost proski]#
P.S. Second attempt, this time with "pio=1" parameter. At least it didn't crash, but it would not work either:
ACPI: PCI Interrupt 0000:0c:00.0[A] -> GSI 17 (level, low) -> IRQ 17
PCI: Setting latency timer of device 0000:0c:00.0 to 64
ssb: Sonics Silicon Backplane found on PCI device 0000:0c:00.0
wmaster0: Selected rate control algorithm 'simple'bcm43xx_d80211: Adding Interface type 2bcm43xx_d80211: Found PHY: Version 4, Type 2, Revision 8bcm43xx_d80211: Found Radio: Manuf 0x17F, Version 0x2050, Revision 2bcm43xx_d80211: Loading firmware version 351.126 (2006-07-29 05:54:02)bcm43xx_d80211: Radio turned onbcm43xx_d80211: FIXME: Possibly broken code in bcm43xx_phy_initg()
at /home/proski/src/linux-2.6/drivers/net/wireless/d80211/bcm43xx/bcm43xx_phy.c:1650bcm43xx_d80211: Chip initializedbcm43xx_d80211: ERROR: This card does not support PIO operation mode. Please use DMA mode (module parameter pio=0).bcm43xx_d80211: Radio turned off
Signature · 2 lines
Regards, Pavel Roskin
Quoted 9 lines · Pavel Roskin
Hello, Michael!
I've tried the master branch of bcm43xx-wireless-dev.git for the first time. The results are not encouraging so far (although I'm quite new to this chipset).
drivers/ssb/driver_mips/mips.cincludesasm/time.h, which is missing onx86_64. It also refers to structssb_serial_ports, which is not defined anywhere.
Yeah, CONFIG_SSB_MIPS should depend on the MIPS CPU. Which kconfig option do you suggest to make a "depend" on?
Quoted 2 lines
drivers/ssb/driver_pci/pcicore.crefers toSSB_PCICORE_SBTOPCI1_CFG1that is not defined anywhere in the kernel.
Yeah, could be a typo. I'll have a look at it.
Quoted 3 lines
I could send you huge logs, but I think it's already a clear sign that you didn't compile-test the current tree with
CONFIG_SSB_DRIVER_MIPSenabled. Things are better if it is disabled.
It is tested. But obviously on MIPS platform.
Quoted 4 lines
In case you haven't seen those warnings:
/home/proski/src/linux-2.6/drivers/net/wireless/d80211/bcm43xx/bcm43xx_main.c:843: warning: 'bcm43xx_wireless_core_mark_inactive' defined but not used/home/proski/src/linux-2.6/drivers/net/wireless/d80211/bcm43xx/bcm43xx_main.c:3032: warning: 'bcm43xx_bluetooth_coext_enable' defined but not used
I am very well aware of these warnings, as they mark unimplemented features.
Quoted 52 lines
I could compile the code, and it even loaded as a module, but the kernel oopsed once I brought wlan0 up by ifconfig.
bcm43xx_d80211: Adding Interface type 2bcm43xx_d80211: Found PHY: Version 4, Type 2, Revision 8bcm43xx_d80211: Found Radio: Manuf0x17F, Version0x2050, Revision 2bcm43xx_d80211: Loading firmware version 351.126 (2006-07-29 05:54:02)bcm43xx_d80211: Radio turned onbcm43xx_d80211: FIXME: Possibly broken code inbcm43xx_phy_initg()at/home/proski/src/linux-2.6/drivers/net/wireless/d80211/bcm43xx/bcm43xx_phy.c:1650bcm43xx_d80211: Chip initializedUnable to handle kernel NULL pointer dereference at 0000000000000000 RIP: [<ffffffff8021eee6>] dma_alloc_coherent+0x52/0x23f PGD 50d1067 PUD 5201067 PMD 0 Oops: 0000 [1] SMP CPU 1 Modules linked in: bcm43xx_d80211 ssb Pid: 2623, comm: ifconfig Not tainted 2.6.20-rc3 #5 RIP: 0010:[<ffffffff8021eee6>] [<ffffffff8021eee6>] dma_alloc_coherent+0x52/0x23f RSP: 0018:ffff810005127bd8 EFLAGS: 00010206 RAX: 0000000000000000 RBX: 0000000000003500 RCX: 00000000000010d4 RDX: 00000000ffffffff RSI: 0000000000001000 RDI: ffff81000196c3a8 RBP: 00000000000010d0 R08: ffff81001f6d1600 R09: 0000000000000004 R10: 0000000000000001 R11: ffff810001122c60 R12: 0000000000001000 R13: ffff810001b96000 R14: ffff81000196c3a8 R15: 00000000ffffffff FS: 00002b411b2133b0(0000) GS:ffff810001827440(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 000000008005003b CR2: 0000000000000000 CR3: 0000000015fdf000 CR4: 00000000000006e0 Process ifconfig (pid: 2623, threadinfo ffff810005126000, task ffff81001f58d180) Stack: ffff81001ee6a3c0 ffff81001ee6a3e8 ffff810001b96000 0000000000003500 ffff81001ee6a3c0 0000000000000080 ffff810001b96000 0000000000000000 0000000000000000 ffffffff88019966 0000000000000005 0000000100000036 Call Trace: [<ffffffff88019966>] :bcm43xx_d80211:bcm43xx_setup_dmaring+0x1a7/0x460 [<ffffffff88019ea3>] :bcm43xx_d80211:bcm43xx_dma_init+0xc0/0x290 [<ffffffff88008131>] :bcm43xx_d80211:bcm43xx_wireless_core_init+0x78f/0x9f1 [<ffffffff8022885e>] mntput_no_expire+0x19/0x77 [<ffffffff8020a3c3>] do_page_fault+0x40b/0x74a [<ffffffff88009f4e>] :bcm43xx_d80211:bcm43xx_add_interface+0x67/0xeb [<ffffffff804378d2>] ieee80211_open+0x1c6/0x2c5 [<ffffffff803fd3ec>] dev_open+0x2f/0x6e [<ffffffff803fbcd5>] dev_change_flags+0x5a/0x119 [<ffffffff80423bab>] devinet_ioctl+0x235/0x59c [<ffffffff803f4bef>] sock_ioctl+0x1c8/0x1e5 [<ffffffff8023b862>] do_ioctl+0x21/0x6b [<ffffffff8022b614>] vfs_ioctl+0x25c/0x275 [<ffffffff8024559b>] sys_ioctl+0x3c/0x5c [<ffffffff802548ee>] system_call+0x7e/0x83 Code: 4c 23 38 49 39 d7 0f 46 e9 49 8d 44 24 ff 83 ca ff 49 89 c5 RIP [<ffffffff8021eee6>] dma_alloc_coherent+0x52/0x23f RSP <ffff810005127bd8>
Quoted 1 line
CR2: 0000000000000000
Hm, not sure why this oopses. It works on PPC (can transmit data and so on).
Quoted 2 lines
It's Fedora Core 6
x86_64on a Dell Latitude with Core 2 Duo and an PCIe wireless card. SMP is enabled. From .config:
PCIe is a seperate issue and not really supported by bcm43xx.
Quoted 5 lines
CONFIG_BCM43XX_D80211=mCONFIG_BCM43XX_D80211_PCI=yCONFIG_BCM43XX_D80211_DEBUG=yCONFIG_BCM43XX_D80211_DMA=yCONFIG_BCM43XX_D80211_PIO=y
Quoted 8 lines
CONFIG_BCM43XX_D80211_DMA_AND_PIO_MODE=y
#CONFIG_BCM43XX_D80211_DMA_MODEis not set
#CONFIG_BCM43XX_D80211_PIO_MODEis not set
[skip]CONFIG_SSB=m
#CONFIG_SSB_SILENTis not set
#CONFIG_SSB_DEBUGis not setCONFIG_SSB_DRIVER_EXTIF=y
You can disable that. I think that should probably depend on CONFIG_SSB_DRIVER_MIPS. I'll take a look.
Quoted 13 lines
#
CONFIG_SSB_DRIVER_MIPSis not set[root@localhost proski]# lspci -v -s 0c:00.0
0c:00.0 Network controller: Broadcom Corporation BCM4310 UART (rev 01)
Subsystem: Dell Unknown device 0007
Flags: bus master, fast devsel, latency 0, IRQ 17
Memory atefdfc000(32-bit, non-prefetchable) [size=16K]
Capabilities: [40] Power Management version 2
Capabilities: [58] Message Signalled Interrupts: 64bit- Queue=0/0 Enable-
Capabilities: [d0] Express Legacy Endpoint IRQ 0
Capabilities: [100] Advanced Error Reporting
Capabilities: [13c] Virtual Channel
Quoted 6 lines
[root@localhost proski]# lspci -n -s 0c:00.0
0c:00.0 0280: 14e4:4312 (rev 01)
[root@localhost proski]#
P.S. Second attempt, this time with "pio=1" parameter. At least it didn't crash, but it would not work either:
Does it work with linville's tree (in DMA mode)?
Signature · 1 line
Greetings Michael.