Fix some ARM builds due to HID brokenness
PATCH 1/1 Fix some ARM builds due to HID brokenness
Could we please have this (or a proper fix) in before 2.6.20 to resolve the regression please?
----- Forwarded message from Russell King <[email protected]> -----
Date: Fri, 22 Dec 2006 17:09:16 +0000
From: Russell King <[email protected]>
To: Linux Kernel List <[email protected]>
Cc: [email protected], [email protected]
Subject: [PATCH] Fix some ARM builds due to HID brokenness
The new location for HID is extremely annoying:
1. the help text implies that you need to enable it for any keyboard or mouse attached to the system. This is not correct.
2. it defaults to 'y'. When you have input deselected, this causes the kernel to fail to link:
drivers/built-in.o: In function `usb_hidinput_input_event':
hid-input.c:(.text+0x55054): undefined reference to input_ff_event' drivers/built-in.o: In function hidinput_hid_event':
hid-input.c:(.text+0x6446c): undefined reference to input_event' hid-input.c:(.text+0x644f8): undefined reference to input_event' hid-input.c:(.text+0x64550): undefined reference to input_event' hid-input.c:(.text+0x64590): undefined reference to input_event' hid-input.c:(.text+0x645b8): undefined reference to input_event' drivers/built-in.o: In function hidinput_disconnect':
hid-input.c:(.text+0x64624): undefined reference to input_unregister_device' drivers/built-in.o: In function hidinput_report_event':
hid-input.c:(.text+0x64670): undefined reference to input_event' drivers/built-in.o: In function hidinput_connect':
hid-input.c:(.text+0x64824): undefined reference to input_allocate_device' hid-input.c:(.text+0x675e0): undefined reference to input_register_device' hid-input.c:(.text+0x67698): undefined reference to input_free_device' hid-input.c:(.text+0x676b8): undefined reference to input_register_device'
make: *** [.tmp_vmlinux1] Error 1
Fix the second problem by making it depend on INPUT. The first problem is left as an exercise for the HID maintainers to solve.
drivers/hid/Kconfig +1 -0
@@ -6,6 +6,7 @@ menu "HID Devices" config HID tristate "Generic HID support" + depends on INPUT default y ---help--- Say Y here if you want generic HID support to connect keyboards,
----- End forwarded message -----
Quoted 2 lines · Russell King
Could we please have this (or a proper fix) in before 2.6.20 to resolve the regression please?
Actually, this remaining regression is not caused by this patch not being integrated, but this:
config USB_HID
tristate "USB Human Interface Device (full HID) support" default y
depends on USB
select HID
So... we have USB_HID _newly_ selected in configurations which didn't have it before, which overrides CONFIG_HID and builds HID without input support.
Relevant lines from "make ep93xx_defconfig" output:
Generic input layer (needed for keyboard, mouse, ...) (INPUT) [N/m/y/?] n Support for Host-side USB (USB) [Y/n/m/?] y
USB Human Interface Device (full HID) support (USB_HID) [Y/n/m/?] (NEW) y
Can USB_HID also depend on INPUT ?
Quoted 60 lines
----- Forwarded message from Russell King <[email protected]> -----
Date: Fri, 22 Dec 2006 17:09:16 +0000
From: Russell King <[email protected]>
To: Linux Kernel List <[email protected]>
Cc: [email protected], [email protected]
Subject: [PATCH] Fix some ARM builds due to HID brokennessThe new location for HID is extremely annoying:
1. the help text implies that you need to enable it for any keyboard or mouse attached to the system. This is not correct.
2. it defaults to 'y'. When you have input deselected, this causes the kernel to fail to link:
drivers/built-in.o: In function `usb_hidinput_input_event':
hid-input.c:(.text+0x55054): undefined reference toinput_ff_event' drivers/built-in.o: In functionhidinput_hid_event':
hid-input.c:(.text+0x6446c): undefined reference toinput_event' hid-input.c:(.text+0x644f8): undefined reference toinput_event' hid-input.c:(.text+0x64550): undefined reference toinput_event' hid-input.c:(.text+0x64590): undefined reference toinput_event' hid-input.c:(.text+0x645b8): undefined reference toinput_event' drivers/built-in.o: In functionhidinput_disconnect':
hid-input.c:(.text+0x64624): undefined reference toinput_unregister_device' drivers/built-in.o: In functionhidinput_report_event':
hid-input.c:(.text+0x64670): undefined reference toinput_event' drivers/built-in.o: In functionhidinput_connect':
hid-input.c:(.text+0x64824): undefined reference toinput_allocate_device' hid-input.c:(.text+0x675e0): undefined reference toinput_register_device' hid-input.c:(.text+0x67698): undefined reference toinput_free_device' hid-input.c:(.text+0x676b8): undefined reference toinput_register_device'
make: *** [.tmp_vmlinux1] Error 1Fix the second problem by making it depend on INPUT. The first problem is left as an exercise for the HID maintainers to solve.
Signed-off-by Russell King <[email protected]>drivers/hid/Kconfig +1
-2@@ -6,6 +6,7 @@ menu "HID Devices" config HID tristate "Generic HID support" + depends on INPUT default y ---help--- Say Y here if you want generic HID support to connect keyboards, ----- End forwarded message ----- -To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Signature · 3 lines
Russell King Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of:
Quoted 17 lines · Russell King
Quoted 2 lines · Russell King
Could we please have this (or a proper fix) in before 2.6.20 to resolve the regression please?
Actually, this remaining regression is not caused by this patch not being integrated, but this:
config
USB_HID
tristate "USB Human Interface Device (full HID) support" default y
depends on USB
select HIDSo... we have
USB_HID_newly_ selected in configurations which didn't have it before, which overridesCONFIG_HIDand builds HID without input support.
Quoted 7 lines
Relevant lines from "make
ep93xx_defconfig" output:Generic input layer (needed for keyboard, mouse, ...) (INPUT) [N/m/y/?] n Support for Host-side USB (USB) [Y/n/m/?] y
USB Human Interface Device (full HID) support (USB_HID) [Y/n/m/?] (NEW) yCan
USB_HIDalso depend on INPUT ?
Nevertheless, here's a patch to solve more of the same that my original patch attempted to solve. The original patch is still required. Seems to solve the final instance of this problem here.
drivers/usb/input/Kconfig +1 -1
@@ -7,7 +7,7 @@ comment "USB Input Devices" config USB_HID tristate "USB Human Interface Device (full HID) support" default y - depends on USB + depends on USB && INPUT select HID ---help--- Say Y here if you want full HID support to connect USB keyboards,
Signature · 3 lines
Russell King Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of:
Quoted 6 lines · Russell King
Quoted 3 lines
So... we have
USB_HID_newly_ selected in configurations which didn't have it before, which overridesCONFIG_HIDand builds HID without input support. CanUSB_HIDalso depend on INPUT ?Nevertheless, here's a patch to solve more of the same that my original patch attempted to solve. The original patch is still required. Seems to solve the final instance of this problem here.
Yes, it is by the time being needed for USB_HID to depend on input. Thanks for the patch, I applied it to HID tree and will push it upstream in the next round.
Signature · 2 lines
Jiri Kosina SUSE Labs
Quoted 10 lines · On Fri, 12 Jan 2007 21:00:15 +0000 Russell King <[email protected]>…
Could we please have this (or a proper fix) in before 2.6.20 to resolve the regression please?
...
drivers/hid/Kconfig menu "HID Devices" · line 12
Quoted 7 lines
drivers/hid/Kconfig +1
-0@@ -6,6 +6,7 @@ menu "HID Devices" config HID tristate "Generic HID support" + depends on INPUT default y ---help--- Say Y here if you want generic HID support to connect keyboards,
This was merged a week ago..
Quoted 13 lines · On Fri, 12 Jan 2007 13:44:05 -0800 Andrew Morton wrote:
Quoted 10 lines · On Fri, 12 Jan 2007 21:00:15 +0000 Russell King <[email protected]>…
Could we please have this (or a proper fix) in before 2.6.20 to resolve the regression please?
...
drivers/hid/Kconfig +0
-0@@ -6,6 +6,7 @@ menu "HID Devices"
Quoted 9 lines
drivers/hid/Kconfig menu "HID Devices" · line 12
Quoted 7 lines
drivers/hid/Kconfig +1
-0config HID tristate "Generic HID support" + depends on INPUT default y ---help--- Say Y here if you want generic HID support to connect keyboards,This was merged a week ago..
Right, we are past that to a new patch now.
---
~Randy