Skip to contentSkip to conversation

Build regression since 2.6.19-git7: jffs2

PATCH In review Russell King 3 participants 3 messages Jan 12, 2007 – Jan 13, 2007 Journalling flash file system V2 (JFFS2)

lore
Share & tools
lore

Russell King

author
#0 lore raw

The following configuration:

CONFIG_JFFS2_FS=y
CONFIG_JFFS2_FS_DEBUG=2
# CONFIG_JFFS2_FS_NAND is not set
# CONFIG_JFFS2_FS_NOR_ECC is not set
# CONFIG_JFFS2_COMPRESSION_OPTIONS is not set
CONFIG_JFFS2_ZLIB=y
CONFIG_JFFS2_RTIME=y
# CONFIG_JFFS2_RUBIN is not set

results in these build errors:

fs/jffs2/malloc.c: In function 'jffs2_alloc_full_dirent':
fs/jffs2/malloc.c:126: error: dereferencing pointer to incomplete type fs/jffs2/malloc.c: In function 'jffs2_free_full_dirent':
fs/jffs2/malloc.c:132: error: dereferencing pointer to incomplete type fs/jffs2/malloc.c: In function 'jffs2_alloc_full_dnode':
fs/jffs2/malloc.c:140: error: dereferencing pointer to incomplete type fs/jffs2/malloc.c: In function 'jffs2_free_full_dnode':
fs/jffs2/malloc.c:146: error: dereferencing pointer to incomplete type fs/jffs2/malloc.c: In function 'jffs2_alloc_raw_dirent':
fs/jffs2/malloc.c:154: error: dereferencing pointer to incomplete type

... etc ...

Signature · 3 lines
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:
#1 lore raw

PATCH 1/1 fix the JFFS2_FS_DEBUG=2 compilation

Quoted 24 lines · Russell King

The following configuration:

CONFIG_JFFS2_FS=y
CONFIG_JFFS2_FS_DEBUG=2
# CONFIG_JFFS2_FS_NAND is not set
# CONFIG_JFFS2_FS_NOR_ECC is not set
# CONFIG_JFFS2_COMPRESSION_OPTIONS is not set
CONFIG_JFFS2_ZLIB=y
CONFIG_JFFS2_RTIME=y
# CONFIG_JFFS2_RUBIN is not set

results in these build errors:

fs/jffs2/malloc.c: In function 'jffs2_alloc_full_dirent':
fs/jffs2/malloc.c:126: error: dereferencing pointer to incomplete type fs/jffs2/malloc.c: In function 'jffs2_free_full_dirent':
fs/jffs2/malloc.c:132: error: dereferencing pointer to incomplete type fs/jffs2/malloc.c: In function 'jffs2_alloc_full_dnode':
fs/jffs2/malloc.c:140: error: dereferencing pointer to incomplete type fs/jffs2/malloc.c: In function 'jffs2_free_full_dnode':
fs/jffs2/malloc.c:146: error: dereferencing pointer to incomplete type fs/jffs2/malloc.c: In function 'jffs2_alloc_raw_dirent':
fs/jffs2/malloc.c:154: error: dereferencing pointer to incomplete type

Quoted 1 line

... etc ...

Thanks for the report, patch below.

cu
Adrian

<-- snip -->

This patch fixes the following CONFIG_JFFS2_FS_DEBUG=2 compile breakage introduced by commit 914e26379decf1fd984b22e51fd2e4209b7a7f1b:

<-- snip -->

...
fs/jffs2/malloc.c: In function 'jffs2_alloc_full_dirent':
fs/jffs2/malloc.c:126: error: dereferencing pointer to incomplete type fs/jffs2/malloc.c: In function 'jffs2_free_full_dirent':
fs/jffs2/malloc.c:132: error: dereferencing pointer to incomplete type fs/jffs2/malloc.c: In function 'jffs2_alloc_full_dnode':
fs/jffs2/malloc.c:140: error: dereferencing pointer to incomplete type fs/jffs2/malloc.c: In function 'jffs2_free_full_dnode':
fs/jffs2/malloc.c:146: error: dereferencing pointer to incomplete type fs/jffs2/malloc.c: In function 'jffs2_alloc_raw_dirent':
fs/jffs2/malloc.c:154: error: dereferencing pointer to incomplete type
...

<-- snip -->

Signed-off-by Adrian Bunk <[email protected]>

commit 3a7722fc440d5214a718bc4b90b7691c04a1af67

Author: Adrian Bunk <[email protected]>
Date:   Sat Jan 13 11:50:44 2007 +0100

sadf

fs/jffs2/debug.h +1 -0
index 3daf3bc..f89c85d 100644
@@ -13,6 +13,7 @@
 #ifndef _JFFS2_DEBUG_H_
 #define _JFFS2_DEBUG_H_
 
+#include <linux/sched.h>
 
 #ifndef CONFIG_JFFS2_FS_DEBUG
 #define CONFIG_JFFS2_FS_DEBUG 0
maintainer
#2 lore raw

Re: [2.6 patch] fix the JFFS2_FS_DEBUG=2 compilation

Quoted 25 lines · Adrian Bunk
Quoted 24 lines · Russell King

The following configuration:

CONFIG_JFFS2_FS=y
CONFIG_JFFS2_FS_DEBUG=2
# CONFIG_JFFS2_FS_NAND is not set
# CONFIG_JFFS2_FS_NOR_ECC is not set
# CONFIG_JFFS2_COMPRESSION_OPTIONS is not set
CONFIG_JFFS2_ZLIB=y
CONFIG_JFFS2_RTIME=y
# CONFIG_JFFS2_RUBIN is not set

results in these build errors:

fs/jffs2/malloc.c: In function 'jffs2_alloc_full_dirent':
fs/jffs2/malloc.c:126: error: dereferencing pointer to incomplete type fs/jffs2/malloc.c: In function 'jffs2_free_full_dirent':
fs/jffs2/malloc.c:132: error: dereferencing pointer to incomplete type fs/jffs2/malloc.c: In function 'jffs2_alloc_full_dnode':
fs/jffs2/malloc.c:140: error: dereferencing pointer to incomplete type fs/jffs2/malloc.c: In function 'jffs2_free_full_dnode':
fs/jffs2/malloc.c:146: error: dereferencing pointer to incomplete type fs/jffs2/malloc.c: In function 'jffs2_alloc_raw_dirent':
fs/jffs2/malloc.c:154: error: dereferencing pointer to incomplete type

Quoted 3 lines
Quoted 1 line

... etc ...

Thanks for the report, patch below.

The patch is already in the MTD git tree, which is still awaiting Linus to pull.

Signature · 1 line
dwmw2