Skip to contentSkip to conversation

atomic_cmpxchg and 64-bit values

DISCUSSION Brent Casavant 3 participants 4 messages Jan 17, 2007 – Jan 18, 2007

lore
Share & tools
lore
#0 lore raw

Hello,

I have what I hope is an easy to answer question.

The IA64 atomic_cmpxchg macro reads as follows (line continuation inserted):

	#define atomic_cmpxchg(v, old, new) \
		((int)cmpxchg(&((v)->counter), old, new))

Note that there's an integer cast on the return from cmpxchg(). This seems strange considering that the entire compxchg() code path takes care to make sure that correctly-sized data types are used throughout, including the return path. The atomic_xchg() macro

Is there some particular reason we need the cast to int on the return path for atomic_cmpxchg()? It looks to me as if this macro would work equally well with an atomic_t or an atomic64_t.

Thanks,
Brent

Signature · 3 lines
Brent Casavant                          All music is folk music.  I ain't
[email protected]                        never heard a horse sing a song.
Silicon Graphics, Inc.                    -- Louis Armstrong
#1 lore raw
Quoted 3 lines · Brent Casavant

Is there some particular reason we need the cast to int on the return path for atomic_cmpxchg()? It looks to me as if this macro would work equally well with an atomic_t or an atomic64_t.

No, this is won't work, atomic_cmpxchg is strictly only defined for atomic_t. See commit 4a6dae6d382e9edf3ff440b819e554ed706359bc.

Andreas.

Signature · 4 lines
Andreas Schwab, SuSE Labs, [email protected]
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."
#2 lore raw
In reply to Brent Casavant
Quoted 8 lines · Andreas Schwab
Quoted 3 lines · Brent Casavant

Is there some particular reason we need the cast to int on the return path for atomic_cmpxchg()? It looks to me as if this macro would work equally well with an atomic_t or an atomic64_t.

No, this is won't work, atomic_cmpxchg is strictly only defined for atomic_t. See commit 4a6dae6d382e9edf3ff440b819e554ed706359bc.

Use cmpxchg instead of atomic_cmpxchg.

#3 lore raw
In reply to Brent Casavant
Quoted 4 lines · Christoph Lameter
Quoted 2 lines · Andreas Schwab

Brent Casavant <[email protected]> writes:

Quoted 8 lines
Quoted 6 lines
Quoted 3 lines

Is there some particular reason we need the cast to int on the return path for atomic_cmpxchg()? It looks to me as if this macro would work equally well with an atomic_t or an atomic64_t.

No, this is won't work, atomic_cmpxchg is strictly only defined for atomic_t. See commit 4a6dae6d382e9edf3ff440b819e554ed706359bc.

Use cmpxchg instead of atomic_cmpxchg.

There was a better solution anyway. I was trying to stash a pointer in the atomic as an ownership token, and that of course was fraught with peril as you need an atomic_t or atomic64_t, depending on platform.

In the end I decided to use a non-pointer unique token rather than deal with the 32/64-bit hassle, which also sidestepped the whole question about the (int) cast.

Thanks you both for the responses though.

Brent

Signature · 3 lines
Brent Casavant                          All music is folk music.  I ain't
[email protected]                        never heard a horse sing a song.
Silicon Graphics, Inc.                    -- Louis Armstrong