Skip to contentSkip to conversation

V4L/DVB fix

PATCH New Mauro Carvalho Chehab 1 participant 2 messages Jan 24, 2007 Media (V4L/DVB)

lore
Share & tools
lore
#0 lore raw

cover V4L/DVB fix

Linus,

Please pull 'master' from:
git://git.kernel.org:/pub/scm/linux/kernel/git/mchehab/v4l-dvb.git
master.

The patch fixes an important bug on V4L core. By doing some ioctls on an unexpected order, it is possible to hang the machine without needing to be root, causing a DoS.

- Buf_qbuf: fix: videobuf_queue->stream corruption and lockup

This patch should also be applied also at -stable releases.

Cheers,
Mauro.

V4L/DVB development is hosted at http://linuxtv.org
---

 drivers/media/video/video-buf.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
#1 lore raw

PATCH 1/1 V4L/DVB (5123): Buf_qbuf: fix: videobuf_queue->stream corruption and lockup

From: Oleg Nesterov <[email protected]>

We are doing ->buf_prepare(buf) before adding buf to q->stream list. This means that videobuf_qbuf() should not try to re-add a STATE_PREPARED buffer.

---

 drivers/media/video/video-buf.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/media/video/video-buf.c +1 -0
index 635d102..6504a58 100644
@@ -700,6 +700,7 @@ videobuf_qbuf(struct videobuf_queue *q,
 		goto done;
 	}
 	if (buf->state == STATE_QUEUED ||
+	    buf->state == STATE_PREPARED ||
 	    buf->state == STATE_ACTIVE) {
 		dprintk(1,"qbuf: buffer is already queued or active.\n");
 		goto done;