AIO - Comment aio_setup_sigevent() explaining why there is no task ref leak
PATCH 1/1 AIO - Comment aio_setup_sigevent() explaining why there is no task ref leak
Here it is
Quoted 7 lines · On Thu, 25 Jan 2007 05:42:42 +0000 Christoph Hellwig <[email protected]> wrote:
Quoted 6 lines · S?bastien Dugu?
Quoted 5 lines
Review
Quoted 2 lines
(quoted diff) +2
-0+ if (unlikely(!notify->sigq)) + return -EAGAIN;Did this just leak a ref on the
task_struct?
Quoted 7 lines
Quoted 2 lines
No, the ref is released in
really_put_req()when we dispose of
the iocb.And the code really needs a comment explaining this. I tripped over this before, and I think it's even already the second time Andrew stumbled over it.
From: Sébastien Dugué <[email protected]>
Add a comment explaining why there is no task ref leak inaio_setup_sigevent().
aio.c | 5 +++++ 1 file changed, 5 insertions(+)
Signed-off-by Sébastien Dugué <[email protected]>
fs/aio.c +5 -0
@@ -987,6 +987,11 @@ static long aio_setup_sigevent(struct ai*/ notify->sigq =sigqueue_alloc (); +/* +* The task ref will be released in really_put_req() +* when we dispose of the iocb later on in the submission +* path. +*/ if (unlikely (!notify->sigq))return -EAGAIN ;