kexec: Avoid migration of already disabled irqs (ia64)

PATCH In review Magnus Damm 2 participants 2 messages Jan 30, 2007 – Jan 31, 2007

lore

Share & tools

lore

Magnus Damm

author

2007-01-30 08:19 UTC #0 lore raw

PATCH 1/1 kexec: Avoid migration of already disabled irqs (ia64)

kexec: Avoid migration of already disabled irqs (ia64)

This patch fixes up ia64 kexec support for HP rx2620 hardware. It does this by skipping migration of already disabled irqs. This is most likely a problem on other ia64 platforms as well, but I've only tested this on one machine so far.

The full story is that handle_bad_irq() gets invoked before starting the new kernel without this patch. This seems to happen when fixup_irqs() calls generic_handle_irq() on already migrated (and disabled) irqs. So by avoiding migration of disabled irqs we stay away of handle_bad_irq().

Signed-off-by Magnus Damm <[email protected]>

---

Tested using kexec-tools-testing 7792798a79b78a5d566f70c9f00237d050b01350 on HP rx2620 hardware.

Applies on top of 2.6.20-rc6.

 arch/ia64/kernel/irq.c |    3 +++
 1 file changed, 3 insertions(+)

arch/ia64/kernel/irq.c +3 -0

@@ -122,6 +122,9 @@ static void migrate_irqs(void)
 	for (irq=0; irq < NR_IRQS; irq++) {
 		desc = irq_desc + irq;
 
+		if (desc->status = IRQ_DISABLED)
+			continue;
+
 		/*
 		 * No handling for now.
 		 * TBD: Implement a disable function so we can now

Horms

Acked-by on v1 1/1

2007-01-31 03:05 UTC #1 lore raw

Quoted 7 lines · Magnus Damm

kexec: Avoid migration of already disabled irqs (ia64)
This patch fixes up ia64 kexec support for HP rx2620 hardware. It does this by skipping migration of already disabled irqs. This is most likely a problem on other ia64 platforms as well, but I've only tested this on one machine so far.

Quoted 6 lines

The full story is that handle_bad_irq() gets invoked before starting the new kernel without this patch. This seems to happen when fixup_irqs() calls generic_handle_irq() on already migrated (and disabled) irqs. So by avoiding migration of disabled irqs we stay away of handle_bad_irq().
Signed-off-by Magnus Damm <[email protected]>

Although I was not seing this problem on my Tiger2, your change doesn't seem to break kexec on that patform :)

Acked-by Simon Horman <[email protected]>

Quoted 22 lines

---

Tested using kexec-tools-testing 7792798a79b78a5d566f70c9f00237d050b01350 on HP rx2620 hardware.

Applies on top of 2.6.20-rc6.

 arch/ia64/kernel/irq.c |    3 +++
 1 file changed, 3 insertions(+)

arch/ia64/kernel/irq.c +3 -0

@@ -122,6 +122,9 @@ static void migrate_irqs(void)
 	for (irq=0; irq < NR_IRQS; irq++) {
 		desc = irq_desc + irq;
 
+		if (desc->status = IRQ_DISABLED)
+			continue;
+
 		/*
 		 * No handling for now.
 		 * TBD: Implement a disable function so we can now