Skip to contentSkip to conversation

(no subject)

PATCH Applied Karsten Wiese 2 participants 2 messages Jan 30, 2007 – Jan 31, 2007

lore
Share & tools
lore
#0 lore raw

Hi Takashi,

some oopses here running -rt kernels vanished after applying this.

Karsten
-------------------------------------------------------------------
snd_hwdep_release() racefix

snd_card_file_remove() can free the snd_card. Touch hw->* only before calling snd_card_file_remove().

Unrelated: Allow hwdep devices not to have own ops.release();

alsa-kernel/core/hwdep.c renamed from alsa-kernel/core/hwdep.c_ +5 -4
@@ -156,15 +156,16 @@
 	int err = -ENXIO;
 	struct snd_hwdep *hw = file->private_data;
 	struct module *mod = hw->card->module;
+
 	mutex_lock(&hw->open_mutex);
-	if (hw->ops.release) {
+	if (hw->ops.release)
 		err = hw->ops.release(hw, file);
-		wake_up(&hw->open_wait);
-	}
 	if (hw->used > 0)
 		hw->used--;
-	snd_card_file_remove(hw->card, file);
 	mutex_unlock(&hw->open_mutex);
+	wake_up(&hw->open_wait);
+
+	snd_card_file_remove(hw->card, file);
 	module_put(mod);
 	return err;
 }

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV

Applied
#1 lore raw

At Tue, 30 Jan 2007 20:51:47 +0100,

Quoted 10 lines · Karsten Wiese

Hi Takashi,

some oopses here running -rt kernels vanished after applying this.

Karsten
-------------------------------------------------------------------
snd_hwdep_release() racefix

Quoted 7 lines

snd_card_file_remove() can free the snd_card. Touch hw->* only before calling snd_card_file_remove().

Unrelated: Allow hwdep devices not to have own ops.release();

Thanks, applied to HG tree.

Takashi

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV