Skip to contentSkip to conversation

floppy.c: first round of cleanup patches - the simple stuff

PATCH Superseded Jesper Juhl 4 participants 5 messages Feb 5, 2007 – Feb 6, 2007 1 message not in the archive

lore
Share & tools
lore

Jesper Juhl

author
#0 lore raw

cover floppy.c: first round of cleanup patches - the simple stuff

Greetings people,

Here is, as promised, the first round of cleanup patches for floppy.c (more will follow later).

I opted to start with the simple stuff first, both to get it out of the way and also to get something done resonably fast, so don't expect anything earth shattering in this first series.

There are 5 patches in this series. They are based on 2.6.20 and are incremental.

These are the patches (they'll be posted to the same recipients as this initial mail) :

[PATCH][1/5] floppy.c: Initial (partial) CodingStyle cleanup [PATCH][2/5] floppy.c: Remove pointless register keywords [PATCH][3/5] floppy.c: Remove dead/commented out code [PATCH][4/5] floppy.c: Add explicit/better printk() levels [PATCH][5/5] floppy.c: Fix device_create_file() warning

The Cc list is composed of people who expressed interrest in this cleanup + people who look like original authors of the code (for whom I could locate email addresses).

Comments and (constructive) criticism is welcome.
And if someone feels like merging this upstream you are most welcome :-)

Kind regards,

Jesper Juhl <[email protected]>

#1 lore raw
Quoted 4 lines · Jesper Juhl

Greetings people,

Here is, as promised, the first round of cleanup patches for floppy.c (more will follow later).

I think the real problem with floppy.c is the basic code logic, not the coding style. While cleaning the later up is nice, I'm afraid it doesn't really help all that much because that code has to be replaced anyways.

-Andi

author
#2 lore raw
Quoted 11 lines · Andi Kleen
Quoted 4 lines · Jesper Juhl

Greetings people,

Here is, as promised, the first round of cleanup patches for floppy.c (more will follow later).

I think the real problem with floppy.c is the basic code logic, not the coding style. While cleaning the later up is nice, I'm afraid it doesn't really help all that much because that code has to be replaced anyways.

And I will get to the logic later, don't worry :-) I just wanted to
get all the simple little things out of the way first.

Thank you for commenting.

Signature · 3 lines
Jesper Juhl <[email protected]>
Don't top-post  http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please      http://www.expita.com/nomime.html
Acked-by Alan Cox on the v1 series
#3 lore raw
In reply to Jesper Juhl
Quoted 12 lines · On Tue, 6 Feb 2007 00:28:31 +0100 Jesper Juhl <[email protected]> wrote:

Greetings people,

Here is, as promised, the first round of cleanup patches for floppy.c (more will follow later).

I opted to start with the simple stuff first, both to get it out of the way and also to get something done resonably fast, so don't expect anything earth shattering in this first series.

There are 5 patches in this series. They are based on 2.6.20 and are incremental.

Quoted 7 lines

These are the patches (they'll be posted to the same recipients as this initial mail) :

[PATCH][1/5] floppy.c: Initial (partial) CodingStyle cleanup [PATCH][2/5] floppy.c: Remove pointless register keywords [PATCH][3/5] floppy.c: Remove dead/commented out code [PATCH][4/5] floppy.c: Add explicit/better printk() levels [PATCH][5/5] floppy.c: Fix device_create_file() warning

Acked-by Alan Cox <[email protected]>

for the set of 5 patches. Its a beginning and removing the dead wood so you can see what is actually there is a good a beginning as any other.

A message that is not in the archive (sent off-list or not yet received): [email protected]

#5 lore raw
Quoted 26 lines · Alan
Quoted 13 lines · On Tue, 6 Feb 2007 00:28:31 +0100 Jesper Juhl <[email protected]> wrote:

Greetings people,

Here is, as promised, the first round of cleanup patches for floppy.c (more will follow later).

I opted to start with the simple stuff first, both to get it out of the way
and also to get something done resonably fast, so don't expect anything earth shattering in this first series.

There are 5 patches in this series. They are based on 2.6.20 and are incremental.

Quoted 8 lines

These are the patches (they'll be posted to the same recipients as this initial mail) :

[PATCH][1/5] floppy.c: Initial (partial) CodingStyle cleanup [PATCH][2/5] floppy.c: Remove pointless register keywords [PATCH][3/5] floppy.c: Remove dead/commented out code [PATCH][4/5] floppy.c: Add explicit/better printk() levels [PATCH][5/5] floppy.c: Fix device_create_file() warning

Quoted 4 lines
Acked-by Alan Cox <[email protected]>

for the set of 5 patches. Its a beginning and removing the dead wood so you can see what is actually there is a good a beginning as any other.

Seconded, looks like a good beginning.
You may also add my ACK for the whole set.

Thanks,
Bart