workqueue: don't save interrupts in run_workqueue()
PATCH 2/6 workqueue: don't save interrupts in run_workqueue()
work->func() may sleep, it's a bug to call run_workqueue() with irqs disabled.
Signed-off-by Oleg Nesterov <[email protected]>
kernel/workqueue.c renamed from kernel/workqueue.c~2_run_irq +4 -10
@@ -227,13 +227,7 @@ EXPORT_SYMBOL_GPL(queue_delayed_work_on)static void run_workqueue (struct cpu_workqueue_struct *cwq) { -unsigned long flags; - -/* -* Keep taking off work from the queue until -* done. -*/ -spin_lock_irqsave (&cwq->lock, flags); +spin_lock_irq (&cwq->lock); cwq->run_depth++;if (cwq->run_depth >3 ) {/* morton gets to eat his hat */
@@ -248,7 +242,7 @@ static void run_workqueue(struct cpu_wor cwq->current_work = work;list_del_init (cwq->worklist.next); -spin_unlock_irqrestore (&cwq->lock, flags); +spin_unlock_irq (&cwq->lock);BUG_ON (get_wq_data (work) != cwq);if (!test_bit (WORK_STRUCT_NOAUTOREL ,work_data_bits (work)))
@@ -266,11 +260,11 @@ static void run_workqueue(struct cpu_wordump_stack (); } -spin_lock_irqsave (&cwq->lock, flags); +spin_lock_irq (&cwq->lock); cwq->current_work =NULL ; } cwq->run_depth--; -spin_unlock_irqrestore (&cwq->lock, flags); +spin_unlock_irq (&cwq->lock); }/*