Skip to contentSkip to conversation

drivers/isdn/gigaset: reduce kernel message spam

PATCH New Tilman Schmidt 1 participant 1 message Feb 7, 2007

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drivers/isdn/gigaset: reduce kernel message spam

Reduce the number of kernel messages the Gigaset drivers produce in case of an excessively long device response, from one per character exceeding the limit to one per overlong message.

---

 isocdata.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/isdn/gigaset/isocdata.c +2 -2
@@ -921,6 +921,8 @@ static void cmd_loop(unsigned char *src,
 			/* end of line */
 			gig_dbg(DEBUG_TRANSCMD, "%s: End of Command (%d Bytes)",
 				__func__, cbytes);
+			if (cbytes >= MAX_RESP_SIZE - 1)
+				dev_warn(cs->dev, "response too large\n");
 			cs->cbytes = cbytes;
 			gigaset_handle_modem_response(cs);
 			cbytes = 0;
@@ -929,8 +931,6 @@ static void cmd_loop(unsigned char *src,
 			/* advance in line buffer, checking for overflow */
 			if (cbytes < MAX_RESP_SIZE - 1)
 				cbytes++;
-			else
-				dev_warn(cs->dev, "response too large\n");
 		}
 	}