Skip to contentSkip to conversation

Linux header change breaks linux-atm userspace build

PATCH Andrew Walrond 2 participants 3 messages Feb 8, 2007 – Feb 9, 2007 ATM

lore
Share & tools
lore
#0 lore raw

Sometime between 2.6.18.3 and 2.6.20, this change...

linux/include/linux/atmarp.h 2007-02-08 20:02:08.000000000 +0000 renamed from include/linux/atmarp.h 2007-01-10 16:32:05.000000000 +0000 +1 -1
@@ -34,7 +34,7 @@
 struct atmarp_ctrl {
        enum atmarp_ctrl_type   type;   /* message type */
        int                     itf_num;/* interface number (if present) */
-       uint32_t                ip;     /* IP address (act_need only) */
+       __be32                  ip;     /* IP address (act_need only) */
 };
 
 #endif

was introduced, but __be32 is undefined, so atmarp.h should include linux/types.h

I've cc'ed Adrian Bunk since he seemed interested last time I reported something like this.

	http://lkml.org/lkml/2007/1/19/39

Hope that is useful.

Andrew Walrond

#1 lore raw

From: Andrew Walrond <[email protected]>
Date: Thu, 8 Feb 2007 21:31:25 +0000

Quoted 14 lines

Sometime between 2.6.18.3 and 2.6.20, this change...

linux/include/linux/atmarp.h 2007-02-08 20:02:08.000000000 +0000 renamed from include/linux/atmarp.h 2007-01-10 16:32:05.000000000 +0000 +1 -1
@@ -34,7 +34,7 @@
 struct atmarp_ctrl {
        enum atmarp_ctrl_type   type;   /* message type */
        int                     itf_num;/* interface number (if present) */
-       uint32_t                ip;     /* IP address (act_need only) */
+       __be32                  ip;     /* IP address (act_need only) */
 };
 
 #endif
Quoted 2 lines

was introduced, but __be32 is undefined, so atmarp.h should include linux/types.h

I'll fix this, thanks for reporting.

#2 lore raw
Quoted 15 lines · David Miller

From: Andrew Walrond <[email protected]>
Date: Thu, 8 Feb 2007 21:31:25 +0000

Quoted 12 lines

Sometime between 2.6.18.3 and 2.6.20, this change...

linux/include/linux/atmarp.h 2007-02-08 20:02:08.000000000 renamed from include/linux/atmarp.h 2007-01-10 16:32:05.000000000 +0000 +1 -0
+0000 @@ -34,7 +34,7 @@
 struct atmarp_ctrl {
        enum atmarp_ctrl_type   type;   /* message type */
        int                     itf_num;/* interface number (if present)
*/ -       uint32_t                ip;     /* IP address (act_need only)
*/ +       __be32                  ip;     /* IP address (act_need only)

*/ };

Quoted 6 lines
Quoted 4 lines

#endif

was introduced, but __be32 is undefined, so atmarp.h should include linux/types.h

I'll fix this, thanks for reporting.

Actually, it seems that several other atm headers are also missing linux/types.h. I guess you can tell which ones have changed recently using git (I just patched linux-atm with liberal #include <linux/types.h>). But let me know if you want a full list.

Andrew Walrond