current git breaks resume

DISCUSSION Jens Axboe 4 participants 12 messages Feb 9, 2007 – Feb 11, 2007 ACPI

Share & tools

Jens Axboe

author

2007-02-09 19:02 UTC #0 lore raw

Hi,

Unfortunately I'm a little short on time as I'll be travelling tomorrow, but of course preparing a new kernel for the laptop is something you want to do right before leaving. So I discovered that the current (well as of yesterday, HEAD is 5986a2ec35836a878350c54af4bd91b1de6abc59) doesn't resume on my x60. 2.6.20 works fine, so something broke since then.

Signature · 1 line

Jens Axboe

Rafael J. Wysocki

2007-02-10 09:51 UTC #1 lore raw

Hi,

Quoted 8 lines · Jens Axboe

Hi,
Unfortunately I'm a little short on time as I'll be travelling tomorrow, but of course preparing a new kernel for the laptop is something you want to do right before leaving. So I discovered that the current (well as of yesterday, HEAD is 5986a2ec35836a878350c54af4bd91b1de6abc59) doesn't resume on my x60. 2.6.20 works fine, so something broke since then.

I think the patch from

http://marc.theaimsgroup.com/?l=linux-acpi&m=117103448629685&w=2

is likely to help.

Greetings,
Rafael

Signature · 3 lines

If you don't have the time to read,
you don't have the time or the tools to write.
		- Stephen King

Jens Axboe

author

2007-02-10 11:24 UTC #2 lore raw

Quoted 12 lines · Rafael J. Wysocki

Hi,
Quoted 8 lines · Jens Axboe
Hi,
Unfortunately I'm a little short on time as I'll be travelling tomorrow, but of course preparing a new kernel for the laptop is something you want to do right before leaving. So I discovered that the current (well as of yesterday, HEAD is 5986a2ec35836a878350c54af4bd91b1de6abc59) doesn't resume on my x60. 2.6.20 works fine, so something broke since then.

Quoted 5 lines

I think the patch from
http://marc.theaimsgroup.com/?l=linux-acpi&m=117103448629685&w=2
is likely to help.

Thanks, will give it a shot.

Signature · 1 line

Jens Axboe

Jens Axboe

author

2007-02-10 11:49 UTC #3 lore raw

Quoted 13 lines · Jens Axboe

Quoted 12 lines · Rafael J. Wysocki
Hi,
Quoted 8 lines · Jens Axboe
Hi,
Unfortunately I'm a little short on time as I'll be travelling tomorrow, but of course preparing a new kernel for the laptop is something you want to do right before leaving. So I discovered that the current (well as of yesterday, HEAD is 5986a2ec35836a878350c54af4bd91b1de6abc59) doesn't resume on my x60. 2.6.20 works fine, so something broke since then.

Quoted 7 lines

Quoted 5 lines
I think the patch from
http://marc.theaimsgroup.com/?l=linux-acpi&m=117103448629685&w=2
is likely to help.
Thanks, will give it a shot.

Doesn't work, still hangs in the same way.

Signature · 1 line

Jens Axboe

Rafael J. Wysocki

2007-02-10 12:00 UTC #4 lore raw

Quoted 16 lines · Jens Axboe

Quoted 15 lines · Jens Axboe
Quoted 14 lines · Rafael J. Wysocki
Hi,
Quoted 8 lines · Jens Axboe
Hi,
Unfortunately I'm a little short on time as I'll be travelling tomorrow, but of course preparing a new kernel for the laptop is something you want to do right before leaving. So I discovered that the current (well as of yesterday, HEAD is 5986a2ec35836a878350c54af4bd91b1de6abc59) doesn't resume on my x60. 2.6.20 works fine, so something broke since then.
I think the patch from

Quoted 7 lines

Quoted 5 lines
Quoted 3 lines
http://marc.theaimsgroup.com/?l=linux-acpi&m=117103448629685&w=2
is likely to help.
Thanks, will give it a shot.
Doesn't work, still hangs in the same way.

Well, looked promising ...

Still, I suspect the ACPI changes cause the problem to happen.

I've tested 2.6.20-git4 and it works on my box (HPC nx6325, x86_64). Unfortunately I have no i386 setup anywhere close to me right now.

Greetings,
Rafael

Jens Axboe

author

2007-02-11 03:28 UTC #5 lore raw

Quoted 23 lines · Rafael J. Wysocki

Quoted 22 lines · Jens Axboe
Quoted 20 lines · Jens Axboe
Quoted 12 lines · Rafael J. Wysocki
Hi,
Quoted 8 lines · Jens Axboe
Hi,
Unfortunately I'm a little short on time as I'll be travelling tomorrow, but of course preparing a new kernel for the laptop is something you want to do right before leaving. So I discovered that the current (well as of yesterday, HEAD is 5986a2ec35836a878350c54af4bd91b1de6abc59) doesn't resume on my x60. 2.6.20 works fine, so something broke since then.
Quoted 5 lines
I think the patch from
http://marc.theaimsgroup.com/?l=linux-acpi&m=117103448629685&w=2
is likely to help.
Thanks, will give it a shot.

Quoted 8 lines

Quoted 1 line
Doesn't work, still hangs in the same way.
Well, looked promising ...
Still, I suspect the ACPI changes cause the problem to happen.
I've tested 2.6.20-git4 and it works on my box (HPC nx6325, x86_64). Unfortunately I have no i386 setup anywhere close to me right now.

When I'm on stable ground again, I'll try with pm tracing and see if that yields anything. Otherwise I'll do a bisect.

Signature · 1 line

Jens Axboe

Len Brown

reviewer

2007-02-11 05:03 UTC #6 lore raw

In reply to Jens Axboe

Quoted 8 lines · Jens Axboe

Hi,
Unfortunately I'm a little short on time as I'll be travelling tomorrow, but of course preparing a new kernel for the laptop is something you want to do right before leaving. So I discovered that the current (well as of yesterday, HEAD is 5986a2ec35836a878350c54af4bd91b1de6abc59) doesn't resume on my x60. 2.6.20 works fine, so something broke since then.

resume from RAM, or resume from disk?

Alexey Starikovskiy

2007-02-11 14:34 UTC #7 lore raw

Quoted 12 lines · Len Brown

Quoted 9 lines · Jens Axboe
Hi,
Unfortunately I'm a little short on time as I'll be travelling tomorrow, but of course preparing a new kernel for the laptop is something you want to do right before leaving. So I discovered that the current (well as of yesterday, HEAD is 5986a2ec35836a878350c54af4bd91b1de6abc59) doesn't resume on my x60. 2.6.20 works fine, so something broke since then.

Quoted 3 lines

resume from RAM, or resume from disk?

Len,
resume from RAM is still broken by "Disable all wakeup GPEs". My previous patch for T43 does not help, only attached one helps (revert original patch).

Disable wake GPEs only once.

From: Alexey Starikovskiy <[email protected]>

---

 drivers/acpi/events/evgpe.c |   11 -----------
 1 files changed, 0 insertions(+), 11 deletions(-)

drivers/acpi/events/evgpe.c +0 ~~-11~~

index dfac3ec..635ba44 100644
@@ -636,17 +636,6 @@ acpi_ev_gpe_dispatch(struct acpi_gpe_eve
 		}
 	}
 
-	if (!acpi_gbl_system_awake_and_running) {
-		/*
-		 * We just woke up because of a wake GPE. Disable any further GPEs
-		 * until we are fully up and running (Only wake GPEs should be enabled
-		 * at this time, but we just brute-force disable them all.)
-		 * 1) We must disable this particular wake GPE so it won't fire again
-		 * 2) We want to disable all wake GPEs, since we are now awake
-		 */
-		(void)acpi_hw_disable_all_gpes();
-	}
-
 	/*
 	 * Dispatch the GPE to either an installed handler, or the control method
 	 * associated with this GPE (_Lxx or _Exx). If a handler exists, we invoke

Jens Axboe

author

2007-02-11 17:15 UTC #8 lore raw

In reply to Len Brown

Quoted 11 lines · Len Brown

Quoted 8 lines · Jens Axboe
Hi,
Unfortunately I'm a little short on time as I'll be travelling tomorrow, but of course preparing a new kernel for the laptop is something you want to do right before leaving. So I discovered that the current (well as of yesterday, HEAD is 5986a2ec35836a878350c54af4bd91b1de6abc59) doesn't resume on my x60. 2.6.20 works fine, so something broke since then.
resume from RAM, or resume from disk?

Resume from RAM, I never use suspend-to-disk.

Signature · 1 line

Jens Axboe

Alexey Starikovskiy

2007-02-11 17:31 UTC #9 lore raw

Quoted 13 lines · Jens Axboe

Quoted 11 lines · Len Brown
Quoted 9 lines · Jens Axboe
Hi,
Unfortunately I'm a little short on time as I'll be travelling tomorrow, but of course preparing a new kernel for the laptop is something you want to do right before leaving. So I discovered that the current (well as of yesterday, HEAD is 5986a2ec35836a878350c54af4bd91b1de6abc59) doesn't resume on my x60. 2.6.20 works fine, so something broke since then.

Quoted 6 lines

Quoted 2 lines
resume from RAM, or resume from disk?
Resume from RAM, I never use suspend-to-disk.

Jens,
Could you please test the patch I've sent?

Thanks,
Alex.

Jens Axboe

author

2007-02-11 17:36 UTC #10 lore raw

Quoted 14 lines · Alexey Starikovskiy

Quoted 13 lines · Jens Axboe
Quoted 11 lines · Len Brown
Quoted 9 lines · Jens Axboe
Hi,
Unfortunately I'm a little short on time as I'll be travelling tomorrow, but of course preparing a new kernel for the laptop is something you want to do right before leaving. So I discovered that the current (well as of yesterday, HEAD is 5986a2ec35836a878350c54af4bd91b1de6abc59) doesn't resume on my x60. 2.6.20 works fine, so something broke since then.

Quoted 8 lines

Quoted 6 lines
Quoted 2 lines
resume from RAM, or resume from disk?
Resume from RAM, I never use suspend-to-disk.
Jens,
Could you please test the patch I've sent?

Just saw it, will do.

Signature · 1 line

Jens Axboe

Jens Axboe

author

2007-02-11 17:56 UTC #11 lore raw

Quoted 18 lines · Jens Axboe

Quoted 17 lines · Alexey Starikovskiy
Quoted 16 lines · Jens Axboe
Quoted 13 lines · Len Brown
Quoted 9 lines · Jens Axboe
Hi,
Unfortunately I'm a little short on time as I'll be travelling tomorrow, but of course preparing a new kernel for the laptop is something you want to do right before leaving. So I discovered that the current (well as of yesterday, HEAD is 5986a2ec35836a878350c54af4bd91b1de6abc59) doesn't resume on my x60. 2.6.20 works fine, so something broke since then.
resume from RAM, or resume from disk?

Quoted 7 lines

Quoted 5 lines
Quoted 3 lines
Resume from RAM, I never use suspend-to-disk.
Jens,
Could you please test the patch I've sent?
Just saw it, will do.

With that patch applied, current git works as expected. Thanks!

Signature · 1 line

Jens Axboe