Skip to contentSkip to conversation

Will smp alternative try to patch init text also?

DISCUSSION Vivek Goyal 2 participants 3 messages Feb 14, 2007

lore
Share & tools
lore
#0 lore raw

Hi,

I just built a 2.6.20 kernel with CONFIG_RELOCATABLE=y. While going through relocation entries for .smp_locks section, I see some relocation entries present w.r.t to init section also. Below I am pasting just few of them.

Relocation section '.rel.smp_locks' at offset 0x6079c8 contains 4662 entries:
Offset Info Type Sym.Value Sym. Name

c058e000  00001201 R_386_32          c0593000   .init.text
c058e004  00001201 R_386_32          c0593000   .init.text
c058e008  00001201 R_386_32          c0593000   .init.text

So what happens if somebody builds a SMP kernel and runs on a UP machine. Later it hotplus one CPU. Then kernel will switch to SMP mode. Looking at the code it looks like it will also try to patch init text which is no more there and will corrupt something else?

Am I missing something?

MODPOST whitelists the references from .smp_locks section to .init.text, hence these warnings are not displayed during compilation.

Thanks
Vivek

#1 lore raw
Quoted 4 lines · Vivek Goyal

So what happens if somebody builds a SMP kernel and runs on a UP machine. Later it hotplus one CPU. Then kernel will switch to SMP mode. Looking at the code it looks like it will also try to patch init text which is no more there and will corrupt something else?

There are range checks for both kernel (_text -> _etext) and modules (.text section). Anything outside isn't patched.

cheers,
Gerd

Signature · 1 line
Gerd Hoffmann <[email protected]>
#2 lore raw
Quoted 9 lines · Gerd Hoffmann
Quoted 4 lines · Vivek Goyal

So what happens if somebody builds a SMP kernel and runs on a UP machine. Later it hotplus one CPU. Then kernel will switch to SMP mode. Looking at the code it looks like it will also try to patch init text which is no more there and will corrupt something else?

There are range checks for both kernel (_text -> _etext) and modules (.text section). Anything outside isn't patched.

Oh... I missed that. Thanks.

Vivek