fault-injection framework on ia64
Andrew Morton
maintainerlib/built-in.o(.text+0x2c192): In function `should_fail':
: undefined reference to `save_stack_trace'
We could disable the feature on ia64, but then they wouldn't be able to inject faults.
2007/2/15, Andrew Morton <[email protected]>:
Quoted 6 lines
lib/built-in.o(.text+0x2c192): In function `should_fail':
: undefined reference to `save_stack_trace'We could disable the feature on ia64, but then they wouldn't be able to inject faults.
I couldn't understand this build error happend.
(I might misunderstand something)
Because IA64 config always disable CONFIG_STACKTRACE, so should_fail() doesn't use save_stack_trace() in fail_stacktrace().
Andrew Morton
maintainerQuoted 5 lines · On Thu, 15 Feb 2007 21:44:34 +0900 "Akinobu Mita" <[email protected]>…
2007/2/15, Andrew Morton <[email protected]>:
Quoted 4 lines
lib/built-in.o(.text+0x2c192): In function `should_fail':
: undefined reference to `save_stack_trace'
Quoted 7 lines
Quoted 2 lines
We could disable the feature on ia64, but then they wouldn't be able to inject faults.
I couldn't understand this build error happend.
(I might misunderstand something)
Because IA64 config always disableCONFIG_STACKTRACE, soshould_fail()doesn't usesave_stack_trace()infail_stacktrace().
OK. Maybe this patch broke things:
From: "Paolo 'Blaisorblade' Giarrusso" <[email protected]>
There is no prompt for STACKTRACE, so it is enabled only when 'select'ed. FAULT_INJECTION depends on it, while LOCKDEP selects it. So FAULT_INJECTION becomes visible in Kconfig only when LOCKDEP is enabled.
---
lib/Kconfig.debug | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
lib/Kconfig.debug renamed from lib/Kconfig.debug~kconfig-fault_injection-can-be-selected-only-if-lockdep-is-enabled +1 -1
@@ -400,7 +400,7 @@ config LKDTM config FAULT_INJECTION bool "Fault-injection framework" depends on DEBUG_KERNEL - depends on STACKTRACE + select STACKTRACE select FRAME_POINTER help Provide fault-injection framework.
_
Quoted 5 lines
Quoted 4 lines
I couldn't understand this build error happend.
(I might misunderstand something)
Because IA64 config always disableCONFIG_STACKTRACE, soshould_fail()doesn't usesave_stack_trace()infail_stacktrace().
Quoted 9 lines
OK. Maybe this patch broke things:
From: "Paolo 'Blaisorblade' Giarrusso" <[email protected]>
There is no prompt for STACKTRACE, so it is enabled only when 'select'ed.
FAULT_INJECTIONdepends on it, while LOCKDEP selects it. SoFAULT_INJECTIONbecomes visible inKconfigonly when LOCKDEP is enabled.
I see. I'll make sub-option for fault injection to enable/disable stacktrace. It'll fix IA64 build problem and unvisible FAULT_INJECTION without LOCKDEP.
Quoted 1 line · Andrew Morton
On Thu, 15 Feb 2007 21:44:34 +0900 "Akinobu Mita" <[email protected]>
Quoted 7 lines · wrote:
Quoted 7 lines
2007/2/15, Andrew Morton <[email protected]>:
Quoted 5 lines
lib/built-in.o(.text+0x2c192): In function `should_fail':
: undefined reference to `save_stack_trace'We could disable the feature on ia64, but then they wouldn't be able to inject faults.
Quoted 6 lines
Quoted 4 lines
I couldn't understand this build error happend.
(I might misunderstand something)
Because IA64 config always disableCONFIG_STACKTRACE, soshould_fail()doesn't usesave_stack_trace()infail_stacktrace().OK. Maybe this patch broke things:
But if STACKTRACE depends on STACKTRACE_SUPPORT, which isn't defined on ia64, kconfig should disable FAULT_INJECTION altogether with my patch (as it did before it). I don't think that FAULT_INJECTION could be enabled before my patch, right?
_BUT_ probably STACKTRACE_SUPPORT should be defined, with default n and no prompt, on ia64, or Kconfig gets confused (it should output a warning, like 'undefined symbol STACKTRACE_SUPPORT'). We on UML used to get warning when INPUT was used but not defined. Hmmm....
I'm interested in this because I also sent the patch to -stable, and Akinobu's patch would be worse to merge there.
Quoted 30 lines
From: "Paolo 'Blaisorblade' Giarrusso" <[email protected]>
There is no prompt for STACKTRACE, so it is enabled only when 'select'ed.
FAULT_INJECTIONdepends on it, while LOCKDEP selects it. SoFAULT_INJECTIONbecomes visible inKconfigonly when LOCKDEP is enabled.Signed-off-by Paolo 'Blaisorblade' Giarrusso <[email protected]>Cc <[email protected]>Cc Akinobu Mita <[email protected]>Signed-off-by Andrew Morton <[email protected]>---
lib/Kconfig.debug | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff -puN
lib/Kconfig.debug~kconfig-fault_injection-can-be-selected-only-if-lockdep-is-enabledlib/Kconfig.debug--- a/lib/Kconfig.debug~kconfig-fault_injection-can-be-selected-only-if-lockdep(quoted diff) +1
-2-is-enabled +++ a/lib/Kconfig.debug@@ -400,7 +400,7 @@ config LKDTM config FAULT_INJECTION bool "Fault-injection framework" depends on DEBUG_KERNEL - depends on STACKTRACE + select STACKTRACE select FRAME_POINTER help Provide fault-injection framework._
Signature · 6 lines
Inform me of my mistakes, so I can add them to my list! Paolo Giarrusso, aka Blaisorblade http://www.user-mode-linux.org/~blaisorblade Chiacchiera con i tuoi amici in tempo reale! http://it.yahoo.com/mail_it/foot/*http://it.messenger.yahoo.com
Quoted 9 lines
But if STACKTRACE depends on
STACKTRACE_SUPPORT, which isn't defined on ia64, kconfig should disableFAULT_INJECTIONaltogether with my patch (as it did before it). I don't think thatFAULT_INJECTIONcould be enabled before my patch, right?_BUT_ probably
STACKTRACE_SUPPORTshould be defined, with default n and no prompt, on ia64, orKconfiggets confused (it should output a warning, like 'undefined symbolSTACKTRACE_SUPPORT'). We on UML used to get warning when INPUT was used but not defined. Hmmm....
Really? I intentionaly removed the STACKTRACE_SUPPORT in x86_64 Kconfig, then I did make menuconfig. But I didn't get such warning.