Skip to contentSkip to conversation

UML - pte_mkread fix

PATCH New Jeff Dike 1 participant 1 message Feb 20, 2007

lore
Share & tools
lore

Jeff Dike

author
#0 lore raw

PATCH 3/3 UML - pte_mkread fix

Fix the fact that pte_mkread set _PAGE_RW instead of _PAGE_USER (the logic is copied from i386 in most place, so it is really as bad as you're thinking).

Thus currently page tables are more permissive than they should.

Such a change may trigger other latent bugs, so be careful with this.

--

 include/asm-um/pgtable.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/asm-um/pgtable.h +1 -1
Index: linux-2.6.18-mm/include/asm-um/pgtable.h
===================================================================
@@ -270,7 +270,7 @@ static inline pte_t pte_wrprotect(pte_t 
 
 static inline pte_t pte_mkread(pte_t pte)
 { 
-	pte_set_bits(pte, _PAGE_RW);
+	pte_set_bits(pte, _PAGE_USER);
 	return(pte_mknewprot(pte)); 
 }
 
Signature · 1 line
Work email - jdike at linux dot intel dot com