Skip to contentSkip to conversation

fault injection: split up stacktrace filter Kconfig option

PATCH Dave Jones 1 participant 1 message Feb 21, 2007 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Dave Jones

author
#1 lore raw
Quoted 17 lines · Linux Kernel
Commit:     1df49008f4ddec9d4f6862b47ea5bdba82078aa4
Parent:     94412a96c4553255bda7a232a349059dd7543338
Author:     Akinobu Mita <[email protected]>
AuthorDate: Tue Feb 20 13:57:56 2007 -0800
Committer:  Linus Torvalds <[email protected]>
CommitDate: Tue Feb 20 17:10:14 2007 -0800

[PATCH] fault injection: split up stacktrace filter Kconfig option

There is no prompt for CONFIG_STACKTRACE, so FAULT_INJECTION cannot be selected without LOCKDEP enabled. (found by Paolo 'Blaisorblade' Giarrusso)

In order to fix such broken Kconfig dependency, this patch splits up the stacktrace filter support for fault injection by new Kconfig option, which enables to use fault injection on the architecture which doesn't have general stacktrace support.

...

Review

Quoted 7 lines
(quoted diff) +7 -0
+config FAULT_INJECTION_STACKTRACE_FILTER
+	bool "stacktrace filter for fault-injection capabilities"
+	depends on FAULT_INJECTION_DEBUG_FS && STACKTRACE_SUPPORT
+	select STACKTRACE
+	select FRAME_POINTER
+	help
+	  Provide stacktrace filter for fault-injection capabilities

This help text is pretty useless. It tells the person configuring nothing about what a stacktrace filter is, or why it might be useful. helptexts that just parrot the name of the option might as well not be there.

Dave

Signature · 1 line
http://www.codemonkey.org.uk