Skip to contentSkip to conversation

Include git-gui credits file in dist.

PATCH In review Shawn O. Pearce 1 participant 2 messages Jun 15, 2016 Kbuild

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Include git-gui credits file in dist.

The Makefile for the git-gui subproject will fail to execute if run outside of a git.git directory, such as when building from a .tar.gz or .tar.bz2. This is because it is looking for the credits file, which was created but omitted from the tarball by the toplevel Makefile.

---

This has to go on maint before you create the release tarball for 1.5.0.2, otherwise 1.5.0.2 cannot be compiled outside of a git.git repository.

 Makefile |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
Makefile +2 -1
index 289decd..35be5e2 100644
@@ -895,7 +895,8 @@ dist: git.spec git-archive
 	$(TAR) rf $(GIT_TARNAME).tar \
 		$(GIT_TARNAME)/git.spec \
 		$(GIT_TARNAME)/version \
-		$(GIT_TARNAME)/git-gui/version
+		$(GIT_TARNAME)/git-gui/version \
+		$(GIT_TARNAME)/git-gui/credits
 	@rm -rf $(GIT_TARNAME)
 	gzip -f -9 $(GIT_TARNAME).tar
 
Signature · 1 line
1.5.0.61.ga0bf
#1 lore raw
Quoted 5 lines · Shawn O. Pearce

The Makefile for the git-gui subproject will fail to execute if run outside of a git.git directory, such as when building from a .tar.gz or .tar.bz2. This is because it is looking for the credits file, which was created but omitted from the tarball by the toplevel Makefile.

Obviously I forgot this little line, sorry:

Quoted 1 line
Signature · 1 line
Shawn.