RFC/patch: down_timeout_interruptible()
Hi All
I was in a situation where I could really simplify many things by using down_interruptible() with a timeout. I went around looking for how could one be implemented and ran away from the asm code in arch/.
At the end I realized I could make a simple one by setting up a timer that would 'fake' a sigpending situation (setting the task's TIF_SIGPENDING bit) so that the __down_interruptible_failed() path would quit when the timer went off.
I gave it a quick try (must admit, not too tested) and it seems that the setting of TIF_SIGPENDING without really having a signal queued is not having easily visible ugly consequences.
Does anybody have suggestions on how to alternatively implement this?
Thanks,
-- Inaky
include/asm-i386/semaphore.h | 3 ++ lib/semaphore-sleepers.c | 51 +++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 54 insertions(+)
include/asm-i386/semaphore.h +3 -0
@@ -88,6 +88,9 @@ fastcall int __down_failed_interruptibl fastcall int __down_failed_interruptible(void /* params in registers */); fastcall int __down_failed_trylock(void /* params in registers */); fastcall void __up_wakeup(void /* special register calling convention */); +/* FIXME: need to add to other header files */ +extern void down_timeout_interruptible (struct semaphore *); +/* * This is ugly, but we want the default case to fall through.
lib/semaphore-sleepers.c +51 -0
54 lines not on this page · raw message
Quoted 4 lines
I gave it a quick try (must admit, not too tested) and it seems that the setting of
TIF_SIGPENDINGwithout really having a signal queued is not having easily visible ugly consequences.
what happens if you get a signal around the time the timeout fires?
Quoted 7 lines
From: Arjan van de Ven [mailto:[email protected]]
Quoted 3 lines
I gave it a quick try (must admit, not too tested) and it seems that the setting of
TIF_SIGPENDINGwithout really having a signal queued is not having easily visible ugly consequences.what happens if you get a signal around the time the timeout fires?
Depends of what around means.
+ result = down_interruptible(sem);
+ del_timer(&dit_timer);
+ if (result < 0 && data.result < 0)
+ result = data.result;
This piece of code will catch the 'timeout arrived right before a signal' case. 'data.result' is set by the timeout handler, so it doesn't interfere.
Now, if the timeout arrives right after a signal was delivered but before the thread returns from down_interruptible, then it will also look like a timeout (as that code in the if statement will kick in) -- to some extent, it is 'right' theoretically, as it didn't get the sem before the time expired. TIF_SIGPENDING is still set, so the signal is not lost (unless I miss something else about the signal delivery engine).
The last case, if the timeout arrives after the signal and after down_interruptible returns, nothing in theory. There is a window where the timer could still execute before it is deleted and it would look like a timeout [which theoretically could be right too]. Maybe the result < 0 && data.result < 0 check should be done before del_timer().
Suggestions?
-- Inaky