Skip to contentSkip to conversation

input.c: start on release

DISCUSSION Pete Zaitcev 3 participants 5 messages Feb 23, 2007 – Feb 24, 2007

lore
Share & tools
lore
#0 lore raw

Here's a curious code I found in drivers/input/input.c (2.6.21-rc1):

void input_release_device(struct input_handle *handle) {
....

	if (handle->handler->start)
		handle->handler->start(handle);
}

Is the above supposed to be this way, or you meant ->stop here?

The commit comment says:
Input: fix list iteration in input_release_device()
It says me precisely nothing about the way it's supposed ot be, sorry...

-- Pete

#1 lore raw
Quoted 10 lines · Pete Zaitcev

Here's a curious code I found in drivers/input/input.c (2.6.21-rc1):

void input_release_device(struct input_handle *handle) {
....

       if (handle->handler->start)
               handle->handler->start(handle);
}

Is the above supposed to be this way, or you meant ->stop here?

It should be ->start(). You are probably confused a little by the name of the function. input_release_device() is called when userspace issues ioctl(fd, EVIOCGRAB, 0) releasing (or ungrabbing) the device (as opposed to xxx_release(file, inode) type functions that are called when last user of a file drops off). In our case we want to give handlers a chance to resume their control over device. Right now standard keyboard driver uses start method do bring back in sync LED state of a keyborad-like device after it was released (ungrabbed).

Quoted 5 lines

The commit comment says:
Input: fix list iteration in input_release_device()
It says me precisely nothing about the way it's supposed ot be, sorry...

It reason for ->start was explained in the patch it was introduced in, the changeset you are referring to literally fixes issue with iteration through list in this function.

Signature · 1 line
Dmitry
#2 lore raw
Quoted 8 lines · Dmitry Torokhov
Quoted 5 lines · Pete Zaitcev

void input_release_device(struct input_handle *handle) {
....

       if (handle->handler->start)
               handle->handler->start(handle);
Quoted 8 lines

It should be ->start(). You are probably confused a little by the name of the function. input_release_device() is called when userspace issues ioctl(fd, EVIOCGRAB, 0) releasing (or ungrabbing) the device (as opposed to xxx_release(file, inode) type functions that are called when last user of a file drops off). In our case we want to give handlers a chance to resume their control over device. Right now standard keyboard driver uses start method do bring back in sync LED state of a keyborad-like device after it was released (ungrabbed).

Thanks for the explanation. I suspect people asked you 100 times before. I can see why we would want to do this when a grab ends, but why do we do this on every close of /dev/input/mice? The call path is:

mousedev_release ->
mixdev_release (optional for some majors)
input_close_device ->
input_release_device

Same thing happens upon disconnect, though this is probably harmless, as the device is gone already anyway.

To tell you the truth, all I really want is to hold a static mutex across a call to input_close_device(). Can I do that?

-- Pete

#3 lore raw
Quoted 18 lines · Pete Zaitcev
Quoted 8 lines · Dmitry Torokhov
Quoted 5 lines · Pete Zaitcev

void input_release_device(struct input_handle *handle) {
....

       if (handle->handler->start)
               handle->handler->start(handle);
Quoted 8 lines

It should be ->start(). You are probably confused a little by the name of the function. input_release_device() is called when userspace issues ioctl(fd, EVIOCGRAB, 0) releasing (or ungrabbing) the device (as opposed to xxx_release(file, inode) type functions that are called when last user of a file drops off). In our case we want to give handlers a chance to resume their control over device. Right now standard keyboard driver uses start method do bring back in sync LED state of a keyborad-like device after it was released (ungrabbed).

Quoted 9 lines

Thanks for the explanation. I suspect people asked you 100 times before. I can see why we would want to do this when a grab ends, but why do we do this on every close of /dev/input/mice? The call path is:

mousedev_release ->
mixdev_release (optional for some majors)
input_close_device ->
input_release_device

The actual work withing input_release_device happens only when called for handle that grabbed the device earlier. The reason why we call it when closing a device so that device is not left in grabbed state if userspace forgot to release it voluntarily.

Quoted 5 lines

Same thing happens upon disconnect, though this is probably harmless, as the device is gone already anyway.

To tell you the truth, all I really want is to hold a static mutex across a call to input_close_device(). Can I do that?

Are you trying to fix locking in mousedev?

Signature · 1 line
Dmitry
#4 lore raw
Quoted 4 lines · Dmitry Torokhov
Quoted 2 lines

To tell you the truth, all I really want is to hold a static mutex across a call to input_close_device(). Can I do that?

Are you trying to fix locking in mousedev?

Yes.

-- Pete