Linux 2.6.18.8
Subsystems (15)
We (the -stable team) are announcing the release of the 2.6.18.8 kernel. It contains a number of bugfixes, and all 2.6.18 users are recommended to upgrade.
Barring anything extremely serious, this will be the last 2.6.18 based release.
The diffstat and short summary of the fixes are below.
I'll also be replying to this message with a copy of the patch between 2.6.18.7 and 2.6.18.8, as it is small enough to do so.
The updated 2.6.18.y git tree can be found at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-2.6.18.y.git
and can be browsed at the normal kernel.org git web browser:
www.kernel.org/git/
thanks,
greg k-h
--------
Makefile | 2 arch/x86_64/ia32/ptrace32.c | 1 arch/x86_64/kernel/entry.S | 4 arch/x86_64/kernel/setup64.c | 4 drivers/char/mem.c | 12 - drivers/i2c/chips/ds1337.c | 8 drivers/infiniband/core/mad.c | 2 drivers/infiniband/ulp/srp/ib_srp.c | 2 drivers/infiniband/ulp/srp/ib_srp.h | 2 drivers/media/dvb/dvb-core/dvb_net.c | 4 drivers/media/video/cx88/cx88-cards.c | 2 drivers/media/video/ks0127.c | 8 drivers/media/video/tveeprom.c | 2 drivers/media/video/usbvideo/quickcam_messenger.h | 14 - drivers/media/video/video-buf.c | 1 drivers/net/wireless/bcm43xx/bcm43xx.h | 2 drivers/net/wireless/bcm43xx/bcm43xx_main.c | 8 drivers/net/wireless/bcm43xx/bcm43xx_xmit.h | 10 - drivers/scsi/scsi_lib.c | 1 fs/buffer.c | 21 ++ fs/ext2/super.c | 4 fs/ext3/super.c | 4 fs/hfs/super.c | 2 include/asm-powerpc/current.h | 12 + include/asm-x86_64/system.h | 5 include/media/cx2341x.h | 2 mm/memory.c | 32 ++- mm/mincore.c | 183 +++++++++------------- mm/msync.c | 66 +++---- mm/shmem.c | 7 30 files changed, 223 insertions(+), 204 deletions(-)
Summary of changes from v2.6.18.7 to v2.6.18.8
==============================================
Andi Kleen (1):
Don't leak NT bit into next task
Andrew Morton (1):
grow_buffers() infinite loop fix (CVE-2006-5757, CVE-2006-6060)
Ang Way Chuang (1):
dvb-core: fix bug in CRC-32 checking on 64-bit systems
Badari Pulavarty (1):
Fix for shmem_truncate_range() BUG_ON()
Dirk Eibach (1):
i2c: fix broken ds1337 initialization
Eric Sandeen (1):
hfs_fill_super returns success even if no root inode (CVE-2006-6056)
Grant Likely (1):
V4L: Fix quickcam communicator driver for big endian architectures
Greg Kroah-Hartman (1):
Linux 2.6.18.8
Hans Verkuil (1):
v4l: cx2341x audio_properties is an u16, not u8
Hugh Dickins (4):
read_zero_pagealigned() locking fix
fix msync error on unmapped area
make ppc64 current preempt-safe
fix umask when noACL kernel meets extN tuned for ACLs
Jean Delvare (1):
v4l: cx88: Fix leadtek_eeprom tagging
Larry Finger (1):
bcm43xx: Fix for oops on resume
Linus Torvalds (1):
Fix incorrect user space access locking in mincore() (CVE-2006-4814)
Martin Samuelsson (1):
V4L: fix ks0127 status flags
Michael Buesch (1):
bcm43xx: Fix for oops on ampdu status
Michael Krufky (1):
V4L: tveeprom: autodetect LG TAPC G701D as tuner type 37
Oleg Nesterov (1):
V4L: buf_qbuf: fix videobuf_queue->stream corruption and lockup
Paolo 'Blaisorblade' Giarrusso (1):
x86_64: fix 2.6.18 regression - PTRACE_OLDSETOPTIONS should be accepted
Roland Dreier (2):
IB/srp: Fix FMR mapping for 32-bit kernels and addresses above 4G IB/mad: Fix race between cancel and receive completion
Tejun Heo (1):
SCSI: add missing cdb clearing in scsi_execute()
Makefile +1 -1
@@ -1,7 +1,7 @@ VERSION = 2 PATCHLEVEL = 6 SUBLEVEL = 18 -EXTRAVERSION = .7 +EXTRAVERSION = .8 NAME=Avast! A bilge rat! # *DOCUMENTATION*
arch/x86_64/ia32/ptrace32.c +1 -0
@@ -239,6 +239,7 @@ asmlinkage long sys32_ptrace(long request, u32 pid, u32 addr, u32 data)case PTRACE_SINGLESTEP :case PTRACE_DETACH :case PTRACE_SYSCALL : +case PTRACE_OLDSETOPTIONS :case PTRACE_SETOPTIONS :return sys_ptrace (request, pid, addr, data);
arch/x86_64/kernel/entry.S +4 -0
@@ -146,6 +146,10 @@ /* rdi: prev */ ENTRY(ret_from_fork) CFI_DEFAULT_STACK + push kernel_eflags(%rip) + CFI_ADJUST_CFA_OFFSET 4 + popf # reset kernel eflags + CFI_ADJUST_CFA_OFFSET -4 call schedule_tail GET_THREAD_INFO(%rcx) testl $(_TIF_SYSCALL_TRACE|_TIF_SYSCALL_AUDIT),threadinfo_flags(%rcx)
arch/x86_64/kernel/setup64.c +4 -0
@@ -178,6 +178,8 @@ void __cpuinit check_efer(void) } } +unsigned long kernel_eflags; +/* * cpu_init() initializes state that is per-CPU. Some data is already * initialized (naturally) in the bootstrap process, such as the GDT
@@ -290,4 +292,6 @@ void __cpuinit cpu_init (void)set_debugreg (0UL ,7 );fpu_init (); + +raw_local_save_flags (kernel_eflags); }
drivers/char/mem.c +8 -4
@@ -616,7 +616,8 @@ static inline size_t read_zero_pagealigned(char __user * buf, size_t size) count = size;zap_page_range (vma, addr, count,NULL ); -zeromap_page_range (vma, addr, count,PAGE_COPY ); +if (zeromap_page_range (vma, addr, count,PAGE_COPY )) +break ; size -= count; buf += count;
@@ -683,11 +684,14 @@ out:static int mmap_zero (struct file * file,struct vm_area_struct * vma) { +int err; +if (vma->vm_flags &VM_SHARED )return shmem_zero_setup (vma); -if (zeromap_page_range (vma, vma->vm_start, vma->vm_end - vma->vm_start, vma->vm_page_prot)) -return -EAGAIN ; -return 0 ; + err =zeromap_page_range (vma, vma->vm_start, + vma->vm_end - vma->vm_start, vma->vm_page_prot); +BUG_ON (err == -EEXIST ); +return err; }#else /* CONFIG_MMU */ static ssize_t read_zero(struct file * file, char * buf,
drivers/i2c/chips/ds1337.c +7 -1
@@ -347,13 +347,19 @@ static void ds1337_init_client(struct i2c_client *client)if ((status &0x80 ) || (control &0x80 )) {/* RTC not running */ -u8 buf[16 ]; +u8 buf[1 +16 ];/* First byte is interpreted as address */ struct i2c_msg msg[1 ];dev_dbg (&client->dev,"%s: RTC not running!\n" , __FUNCTION__);/* Initialize all, including STATUS and CONTROL to zero */ memset (buf,0 ,sizeof (buf)); + +/* Write valid values in the date/time registers */ + buf[1 +DS1337_REG_DAY ] =1 ; + buf[1 +DS1337_REG_DATE ] =1 ; + buf[1 +DS1337_REG_MONTH ] =1 ; + msg[0 ].addr = client->addr; msg[0 ].flags =0 ; msg[0 ].len =sizeof (buf);
drivers/infiniband/core/mad.c +1 -1
@@ -1750,7 +1750,7 @@ ib_find_send_mad(struct ib_mad_agent_private *mad_agent_priv,*/ (is_direct (wc->recv_buf.mad->mad_hdr.mgmt_class) || rcv_has_same_gid(mad_agent_priv, wr, wc))) -return wr; + return (wr->status == IB_WC_SUCCESS) ? wr : NULL; }/*
drivers/infiniband/ulp/srp/ib_srp.c +1 -1
@@ -1851,7 +1851,7 @@ static void srp_add_one(struct ib_device *device)*/ srp_dev->fmr_page_shift =max (9 ,ffs (dev_attr->page_size_cap) -1 ); srp_dev->fmr_page_size =1 << srp_dev->fmr_page_shift; - srp_dev->fmr_page_mask = ~((unsigned long ) srp_dev->fmr_page_size -1 ); + srp_dev->fmr_page_mask = ~((u64 ) srp_dev->fmr_page_size -1 );INIT_LIST_HEAD (&srp_dev->dev_list);
drivers/infiniband/ulp/srp/ib_srp.h +1 -1
@@ -87,7 +87,7 @@ struct srp_device {struct ib_fmr_pool *fmr_pool;int fmr_page_shift;int fmr_page_size; -unsigned long fmr_page_mask; +u64 fmr_page_mask; };struct srp_host {
drivers/media/dvb/dvb-core/dvb_net.c +2 -2
@@ -604,7 +604,7 @@ static void dvb_net_ule( struct net_device *dev, const u8 *buf, size_t buf_len ) { &utype, sizeof utype }, { priv->ule_skb->data, priv->ule_skb->len - 4 } }; -unsigned long ule_crc = ~0L , expected_crc; +u32 ule_crc = ~0L , expected_crc;if (priv->ule_dbit) {/* Set D-bit for CRC32 verification, * if it was set originally. */
@@ -617,7 +617,7 @@ static void dvb_net_ule( struct net_device *dev, const u8 *buf, size_t buf_len ) *((u8 *)priv->ule_skb->tail -2 ) <<8 | *((u8 *)priv->ule_skb->tail -1 );if (ule_crc != expected_crc) { -printk (KERN_WARNING "%lu: CRC32 check FAILED: %#lx / %#lx, SNDU len %d type %#x, ts_remain %d, next 2: %x.\n" , +printk (KERN_WARNING "%lu: CRC32 check FAILED: %08x / %08x, SNDU len %d type %#x, ts_remain %d, next 2: %x.\n" , priv->ts_count, ule_crc, expected_crc, priv->ule_sndu_len, priv->ule_sndu_type, ts_remain, ts_remain >2 ? *(unsigned short *)from_where :0 );#ifdef ULE_DEBUG
drivers/media/video/cx88/cx88-cards.c +1 -1
@@ -1465,7 +1465,7 @@ const unsigned int cx88_idcount = ARRAY_SIZE(cx88_subids);/* ----------------------------------------------------------------------- */ /* some leadtek specific stuff */ -static void __devinit leadtek_eeprom (struct cx88_core *core,u8 *eeprom_data) +static void leadtek_eeprom (struct cx88_core *core,u8 *eeprom_data) {/* This is just for the "Winfast 2000XP Expert" board ATM; I don't have data on * any others.
drivers/media/video/ks0127.c +4 -4
@@ -712,13 +712,13 @@ static int ks0127_command(struct i2c_client *client, *iarg =0 ; status =ks0127_read (ks,KS_STAT );if (!(status &0x20 ))/* NOVID not set */ - *iarg = (*iarg &DECODER_STATUS_GOOD ); + *iarg = (*iarg |DECODER_STATUS_GOOD );if ((status &0x01 ))/* CLOCK set */ - *iarg = (*iarg &DECODER_STATUS_COLOR ); + *iarg = (*iarg |DECODER_STATUS_COLOR );if ((status &0x08 ))/* PALDET set */ - *iarg = (*iarg &DECODER_STATUS_PAL ); + *iarg = (*iarg |DECODER_STATUS_PAL );else - *iarg = (*iarg &DECODER_STATUS_NTSC ); + *iarg = (*iarg |DECODER_STATUS_NTSC );break ;//Catch any unknown command
drivers/media/video/tveeprom.c +1 -1
@@ -184,7 +184,7 @@ hauppauge_tuner[] = { TUNER_ABSENT, "Thompson DTT757"},/* 80-89 */ { TUNER_ABSENT, "Philips FQ1216LME MK3"}, - { TUNER_ABSENT, "LG TAPC G701D"}, + { TUNER_LG_PAL_NEW_TAPC, "LG TAPC G701D"}, { TUNER_LG_NTSC_NEW_TAPC, "LG TAPC H791F"}, { TUNER_LG_PAL_NEW_TAPC, "TCL 2002MB 3"}, { TUNER_LG_PAL_NEW_TAPC, "TCL 2002MI 3"},
drivers/media/video/usbvideo/quickcam_messenger.h +0 -14
@@ -35,27 +35,13 @@ struct rgb { };struct bayL0 { -#ifdef __BIG_ENDIAN -u8 r; -u8 g; -#elif __LITTLE_ENDIANu8 g;u8 r; -#else -#error not byte order defined -#endif };struct bayL1 { -#ifdef __BIG_ENDIAN -u8 g; -u8 b; -#elif __LITTLE_ENDIANu8 b;u8 g; -#else -#error not byte order defined -#endif };struct cam_size {
drivers/media/video/video-buf.c +1 -0
@@ -695,6 +695,7 @@ videobuf_qbuf(struct videobuf_queue *q, goto done; }if (buf->state ==STATE_QUEUED || + buf->state ==STATE_PREPARED || buf->state ==STATE_ACTIVE ) {dprintk (1 ,"qbuf: buffer is already queued or active.\n" ); goto done;
drivers/net/wireless/bcm43xx/bcm43xx.h +1 -1
@@ -21,7 +21,7 @@#define PFX KBUILD_MODNAME ": "#define BCM43xx_SWITCH_CORE_MAX_RETRIES 50 -#define BCM43xx_IRQWAIT_MAX_RETRIES 50 +#define BCM43xx_IRQWAIT_MAX_RETRIES 100#define BCM43xx_IO_SIZE 8192
drivers/net/wireless/bcm43xx/bcm43xx_main.c +3 -5
@@ -1449,12 +1449,10 @@ static void handle_irq_transmit_status(struct bcm43xx_private *bcm)bcm43xx_debugfs_log_txstat (bcm, &stat); -if (stat.flags & BCM43xx_TXSTAT_FLAG_IGNORE) +if (stat.flags & BCM43xx_TXSTAT_FLAG_AMPDU) +continue ; +if (stat.flags & BCM43xx_TXSTAT_FLAG_INTER)continue ; -if (!(stat.flags & BCM43xx_TXSTAT_FLAG_ACK)) { -//TODO: packet was not acked (was lost) - } -//TODO: There are more (unknown) flags to test. see bcm43xx_main.h if (bcm43xx_using_pio (bcm))bcm43xx_pio_handle_xmitstatus (bcm, &stat);
drivers/net/wireless/bcm43xx/bcm43xx_xmit.h +2 -8
@@ -137,14 +137,8 @@ struct bcm43xx_xmitstatus {u16 unknown;//FIXME }; -#define BCM43xx_TXSTAT_FLAG_ACK 0x01 -//TODO #define BCM43xx_TXSTAT_FLAG_??? 0x02 -//TODO #define BCM43xx_TXSTAT_FLAG_??? 0x04 -//TODO #define BCM43xx_TXSTAT_FLAG_??? 0x08 -//TODO #define BCM43xx_TXSTAT_FLAG_??? 0x10 -#define BCM43xx_TXSTAT_FLAG_IGNORE 0x20 -//TODO #define BCM43xx_TXSTAT_FLAG_??? 0x40 -//TODO #define BCM43xx_TXSTAT_FLAG_??? 0x80 +#define BCM43xx_TXSTAT_FLAG_AMPDU 0x10 +#define BCM43xx_TXSTAT_FLAG_INTER 0x20u8 bcm43xx_plcp_get_ratecode_cck (const u8 bitrate);u8 bcm43xx_plcp_get_ratecode_ofdm (const u8 bitrate);
drivers/scsi/scsi_lib.c +1 -0
@@ -191,6 +191,7 @@ int scsi_execute(struct scsi_device *sdev, const unsigned char *cmd, goto out; req->cmd_len =COMMAND_SIZE (cmd[0 ]); +memset (req->cmd,0 ,BLK_MAX_CDB );/* ATAPI hates garbage after CDB */ memcpy (req->cmd, cmd, req->cmd_len); req->sense = sense; req->sense_len =0 ;
fs/buffer.c +19 -2
@@ -1179,8 +1179,21 @@ grow_buffers(struct block_device *bdev, sector_t block, int size) }while ((size << sizebits) <PAGE_SIZE ); index = block >> sizebits; - block = index << sizebits; +/* +* Check for a block which wants to lie outside our maximum possible +* pagecache index. (this comparison is done using sector_t types). +*/ +if (unlikely (index != block >> sizebits)) { +char b[BDEVNAME_SIZE ]; + +printk (KERN_ERR "%s: requested out-of-range block %llu for " +"device %s\n" , + __FUNCTION__, (unsigned long long )block, +bdevname (bdev, b)); +return -EIO ; + } + block = index << sizebits;/* Create a page with the proper size buffers.. */ page =grow_dev_page (bdev, block, index, size);if (!page)
@@ -1207,12 +1220,16 @@ __getblk_slow(struct block_device *bdev, sector_t block, int size)for (;;) {struct buffer_head * bh; +int ret; bh =__find_get_block (bdev, block, size);if (bh)return bh; -if (!grow_buffers (bdev, block, size)) + ret =grow_buffers (bdev, block, size); +if (ret <0 ) +return NULL ; +if (ret ==0 )free_more_memory (); } }
fs/ext2/super.c +4 -0
@@ -701,10 +701,14 @@ static int ext2_fill_super(struct super_block *sb, void *data, int silent)set_opt (sbi->s_mount_opt,GRPID );if (def_mount_opts &EXT2_DEFM_UID16 )set_opt (sbi->s_mount_opt,NO_UID32 ); +#ifdef CONFIG_EXT2_FS_XATTR if (def_mount_opts &EXT2_DEFM_XATTR_USER )set_opt (sbi->s_mount_opt,XATTR_USER ); +#endif +#ifdef CONFIG_EXT2_FS_POSIX_ACL if (def_mount_opts &EXT2_DEFM_ACL )set_opt (sbi->s_mount_opt,POSIX_ACL ); +#endif if (le16_to_cpu (sbi->s_es->s_errors) ==EXT2_ERRORS_PANIC )set_opt (sbi->s_mount_opt,ERRORS_PANIC );
fs/ext3/super.c +4 -0
@@ -1451,10 +1451,14 @@ static int ext3_fill_super (struct super_block *sb, void *data, int silent)set_opt (sbi->s_mount_opt,GRPID );if (def_mount_opts &EXT3_DEFM_UID16 )set_opt (sbi->s_mount_opt,NO_UID32 ); +#ifdef CONFIG_EXT3_FS_XATTR if (def_mount_opts &EXT3_DEFM_XATTR_USER )set_opt (sbi->s_mount_opt,XATTR_USER ); +#endif +#ifdef CONFIG_EXT3_FS_POSIX_ACL if (def_mount_opts &EXT3_DEFM_ACL )set_opt (sbi->s_mount_opt,POSIX_ACL ); +#endif if ((def_mount_opts &EXT3_DEFM_JMODE ) ==EXT3_DEFM_JMODE_DATA ) sbi->s_mount_opt |=EXT3_MOUNT_JOURNAL_DATA ;else if ((def_mount_opts &EXT3_DEFM_JMODE ) ==EXT3_DEFM_JMODE_ORDERED )
fs/hfs/super.c +2 -0
@@ -391,11 +391,13 @@ static int hfs_fill_super(struct super_block *sb, void *data, int silent)hfs_find_exit (&fd); goto bail_no_root; } + res = -EINVAL ; root_inode =hfs_iget (sb, &fd.search_key->cat, &rec);hfs_find_exit (&fd);if (!root_inode) goto bail_no_root; + res = -ENOMEM ; sb->s_root =d_alloc_root (root_inode);if (!sb->s_root) goto bail_iput;
include/asm-powerpc/current.h +11 -1
@@ -14,7 +14,17 @@ struct task_struct;#ifdef __powerpc64__#include <asm/paca.h> -#define current (get_paca()->__current) +static inline struct task_struct *get_current (void ) +{ +struct task_struct *task; + + __asm__ __volatile__("ld %0,%1(13)" + :"=r" (task) + :"i" (offsetof(struct paca_struct , __current))); + +return task; +} +#define current get_current()#else
include/asm-x86_64/system.h +3 -2
@@ -14,12 +14,13 @@#define __RESTORE (reg,offset) "movq (14-" #offset ")*8(%%rsp),%%" #reg "\n\t"/* frame pointer must be last for get_wchan */ -#define SAVE_CONTEXT "pushq %%rbp ; movq %%rsi,%%rbp\n\t" -#define RESTORE_CONTEXT "movq %%rbp,%%rsi ; popq %%rbp\n\t" +#define SAVE_CONTEXT "pushf ; pushq %%rbp ; movq %%rsi,%%rbp\n\t" +#define RESTORE_CONTEXT "movq %%rbp,%%rsi ; popq %%rbp ; popf\t"#define __EXTRA_CLOBBER \ ,"rcx","rbx","rdx","r8","r9","r10","r11","r12","r13","r14","r15" +/* Save restore flags to clear handle leaking NT */ #define switch_to (prev,next,last) \ asm volatile(SAVE_CONTEXT \ "movq %%rsp,%P[threadrsp](%[prev])\n\t"/* save RSP */ \
include/media/cx2341x.h +1 -1
@@ -49,7 +49,7 @@ struct cx2341x_mpeg_params {enum v4l2_mpeg_audio_mode_extension audio_mode_extension;enum v4l2_mpeg_audio_emphasis audio_emphasis;enum v4l2_mpeg_audio_crc audio_crc; -u8 audio_properties; +u16 audio_properties;/* video */ enum v4l2_mpeg_video_encoding video_encoding;
mm/memory.c +21 -11
@@ -1104,21 +1104,27 @@ static int zeromap_pte_range(struct mm_struct *mm, pmd_t *pmd, {pte_t *pte;spinlock_t *ptl; +int err =0 ; pte =pte_alloc_map_lock (mm, pmd, addr, &ptl);if (!pte) -return -ENOMEM ; +return -EAGAIN ;do {struct page *page =ZERO_PAGE (addr);pte_t zero_pte =pte_wrprotect (mk_pte (page, prot)); + +if (unlikely (!pte_none (*pte))) { + err = -EEXIST ; + pte++; +break ; + }page_cache_get (page);page_add_file_rmap (page);inc_mm_counter (mm, file_rss); -BUG_ON (!pte_none (*pte));set_pte_at (mm, addr, pte, zero_pte); }while (pte++, addr +=PAGE_SIZE , addr != end);pte_unmap_unlock (pte -1 , ptl); -return 0 ; +return err; } static inline int zeromap_pmd_range(struct mm_struct *mm, pud_t *pud,
@@ -1126,16 +1132,18 @@ static inline int zeromap_pmd_range(struct mm_struct *mm, pud_t *pud, {pmd_t *pmd;unsigned long next; +int err; pmd =pmd_alloc (mm, pud, addr);if (!pmd) -return -ENOMEM ; +return -EAGAIN ;do { next =pmd_addr_end (addr, end); -if (zeromap_pte_range (mm, pmd, addr, next, prot)) -return -ENOMEM ; + err =zeromap_pte_range (mm, pmd, addr, next, prot); +if (err) +break ; }while (pmd++, addr = next, addr != end); -return 0 ; +return err; } static inline int zeromap_pud_range(struct mm_struct *mm, pgd_t *pgd,
@@ -1143,16 +1151,18 @@ static inline int zeromap_pud_range(struct mm_struct *mm, pgd_t *pgd, {pud_t *pud;unsigned long next; +int err; pud =pud_alloc (mm, pgd, addr);if (!pud) -return -ENOMEM ; +return -EAGAIN ;do { next =pud_addr_end (addr, end); -if (zeromap_pmd_range (mm, pud, addr, next, prot)) -return -ENOMEM ; + err =zeromap_pmd_range (mm, pud, addr, next, prot); +if (err) +break ; }while (pud++, addr = next, addr != end); -return 0 ; +return err; } int zeromap_page_range(struct vm_area_struct *vma,
mm/mincore.c +78 -105
213 lines not on this page · raw message
mm/msync.c +30 -36
104 lines not on this page · raw message
mm/shmem.c +6 -1
@@ -510,7 +510,12 @@ static void shmem_truncate_range(struct inode *inode, loff_t start, loff_t end) size =SHMEM_NR_DIRECT ; nr_swaps_freed =shmem_free_swp (ptr+idx, ptr+size); } -if (!topdir) + +/* +* If there are no indirect blocks or we are punching a hole +* below indirect blocks, nothing to be done. +*/ +if (!topdir || (punch_hole && (limit <=SHMEM_NR_DIRECT ))) goto done2;BUG_ON (limit <=SHMEM_NR_DIRECT );