patch 3 / 3: fix floppy mount bug in kernel 2.6.21-rc1
Hi folks,
this patch fixes the floppy mount bug (i. e. regression) in kernel 2.6.21-rc1. It was inspired by Stephane Eranian. It was tested on an Intel P4 1800 MHz (Intel ICH4 chipset) and on an AMD Athlon XP 1800 MHz (Silicon Integrated Systems chipset 740, 5513).
My deep thanks and respect go to:
Stephane Eranian, Linus Torvalds, Jiri Slaby. You are truthfully real men and reliable, accurate, fine chaps. It feels great to have you in this world-wide community! Would you still call the whole i386 architecture "a small number of machines", Mister Andrew Morton? If yes, in how far please?
arch/i386/kernel/process.c +1 -0
@@ -154,6 +154,7 @@current_thread_info ()->status |=TS_POLLING ; }else {/* loop is done by the caller */ +local_irq_enable ();cpu_relax (); } }
Signature · 2 lines
"Feel free" - 10 GB Mailbox, 100 FreeSMS/Monat ... Jetzt GMX TopMail testen: www.gmx.net/de/go/mailfooter/topmail-out
Quoted 12 lines · On Thu, 01 Mar 2007 15:32:22 +0100 "Uwe Bugla" <[email protected]> wrote:
Hi folks,
this patch fixes the floppy mount bug (i. e. regression) in kernel 2.6.21-rc1. It was inspired by Stephane Eranian. It was tested on an Intel P4 1800 MHz (Intel ICH4 chipset) and on an AMD Athlon XP 1800 MHz (Silicon Integrated Systems chipset 740, 5513).
My deep thanks and respect go to:
Stephane Eranian, Linus Torvalds, Jiri Slaby. You are truthfully real men and reliable, accurate, fine chaps. It feels great to have you in this world-wide community! Would you still call the whole i386 architecture "a small number of machines", Mister Andrew Morton? If yes, in how far please?Signed-off-by Uwe Bugla <[email protected]>
arch/i386/kernel/process.c line 160
Quoted 7 lines
arch/i386/kernel/process.c +1
-0@@ -154,6 +154,7 @@current_thread_info ()->status |=TS_POLLING ; }else {/* loop is done by the caller */ +local_irq_enable ();cpu_relax (); } }
Linus reverted the offending patch "[PATCH] i386: add idle notifier" on Feb 26, so this fix should no longer be needed, and 2.6.21-rc2 should be working again.
Hopefully Stephane will fold this fix into any future version of that patch, if appropriate.
Andrew,
Quoted 27 lines · Andrew Morton
Quoted 12 lines · On Thu, 01 Mar 2007 15:32:22 +0100 "Uwe Bugla" <[email protected]> wrote:
Hi folks,
this patch fixes the floppy mount bug (i. e. regression) in kernel 2.6.21-rc1. It was inspired by Stephane Eranian. It was tested on an Intel P4 1800 MHz (Intel ICH4 chipset) and on an AMD Athlon XP 1800 MHz (Silicon Integrated Systems chipset 740, 5513).
My deep thanks and respect go to:
Stephane Eranian, Linus Torvalds, Jiri Slaby. You are truthfully real men and reliable, accurate, fine chaps. It feels great to have you in this world-wide community! Would you still call the whole i386 architecture "a small number of machines", Mister Andrew Morton? If yes, in how far please?Signed-off-by Uwe Bugla <[email protected]>arch/i386/kernel/process.c line 160
Quoted 7 lines
arch/i386/kernel/process.c +1
-0@@ -154,6 +154,7 @@current_thread_info ()->status |=TS_POLLING ; }else {/* loop is done by the caller */ +local_irq_enable ();cpu_relax (); } }Linus reverted the offending patch "[PATCH] i386: add idle notifier" on Feb 26, so this fix should no longer be needed, and 2.6.21-rc2 should be working again.
Quoted 2 lines
Hopefully Stephane will fold this fix into any future version of that patch, if appropriate.
Well, given that nobody really liked this idle notifier, I am trying to do differently on all architectures which unfortunately is not an easy thing to do.
What I did not really like in all of this is that people come up with arguments without providing the data to prove it, e.g., increase interrupt latency (by how much?).
Signature · 1 line
-Stephane