Skip to contentSkip to conversation

pata_jmicron: remove spurious #endif

PATCH In review Luca Tettamanti 2 participants 3 messages Mar 3, 2007 – Mar 5, 2007 libata

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 pata_jmicron: remove spurious #endif

Hello,
commit 438ac6d5e3f8106a6bd1a5682c508d660294a85d causes a build failure:

CC drivers/ata/pata_jmicron.o
/home/kronos/src/linux-2.6.git/drivers/ata/pata_jmicron.c:247:2: error: #endif without #if make[3]: *** [drivers/ata/pata_jmicron.o] Error 1

Remove a spurious #endif in pata_jmicron driver.

---

 drivers/ata/pata_jmicron.c |    1 -
 1 file changed, 1 deletion(-)
drivers/ata/pata_jmicron.c +0 -1
index 033319e..43763c9 100644
@@ -244,7 +244,6 @@ static void __exit jmicron_exit(void)
 {
 	pci_unregister_driver(&jmicron_pci_driver);
 }
-#endif
 
 module_init(jmicron_init);
 module_exit(jmicron_exit);

Luca

Signature · 2 lines
You and me baby ain't nothin' but mammals
So let's do it like they do on the Discovery Channel
#1 lore raw
Quoted 8 lines · Luca Tettamanti

Hello,
commit 438ac6d5e3f8106a6bd1a5682c508d660294a85d causes a build failure:

CC drivers/ata/pata_jmicron.o
/home/kronos/src/linux-2.6.git/drivers/ata/pata_jmicron.c:247:2: error: #endif without #if make[3]: *** [drivers/ata/pata_jmicron.o] Error 1

Remove a spurious #endif in pata_jmicron driver.

I think the problem is that Tejun forgot to *add* a #ifdef CONFIG_PM instead.

Cheers,

Auke

#2 lore raw
Quoted 11 lines · Auke
Quoted 8 lines · Luca Tettamanti

Hello,
commit 438ac6d5e3f8106a6bd1a5682c508d660294a85d causes a build failure:

CC drivers/ata/pata_jmicron.o
/home/kronos/src/linux-2.6.git/drivers/ata/pata_jmicron.c:247:2: error: #endif without #if make[3]: *** [drivers/ata/pata_jmicron.o] Error 1

Remove a spurious #endif in pata_jmicron driver.

I think the problem is that Tejun forgot to *add* a #ifdef CONFIG_PM instead.

Nope, that #endif was after the jmicron_exit() function which is unrelated with CONFIG_PM. I see that Jeff has already commited a similar patch, mine is no longer needed.

Luca