Skip to contentSkip to conversation

mv kernel/acpi/processor.c

PATCH Linus Torvalds 2 participants 2 messages Mar 13, 2007 – Mar 14, 2007 2 messages not in the archive

lore
Share & tools
lore
#2 lore raw
In reply to a message not in the archive
Quoted 2 lines · Steven Rostedt

Move kernel/acpi/processor.c to the common hold.

Please use

git diff -M

for things like this.

In fact, even if you weren't a git user, I'd ask you to *become* one just because I think that it's a *lot* more productive if people actually see renames as renames, and will see what - if anything - changed when renaming.

The "-M" flag isn't the default, simply because it generates patches that cannot be applied with regular "patch", but for something like this, I think it's practically imperative. The old kind of "remove file" + "add file" patch just isn't acceptable when there are very viable alternaties.

You don't even have to use a git repository to use a git rename patch - you just need to use "git apply" to apply it.

Linus

#3 lore raw
Quoted 8 lines · Linus Torvalds
Quoted 2 lines · Steven Rostedt

Move kernel/acpi/processor.c to the common hold.

Please use

git diff -M

OK, thanks! I'm still quite a git-nubie.

I'll update all the move patches. It may take a bit of hand work.

What I really did to do this patch series was to make all my changes in git. But the changes where not smooth from change set to change set. So I did one big git-diff, and then used good old midnight commander (mc) to parse the patches. And then pulled them into quilt to comment and send them.

Quoted 8 lines

for things like this.

In fact, even if you weren't a git user, I'd ask you to *become* one just because I think that it's a *lot* more productive if people actually see renames as renames, and will see what - if anything - changed when renaming.

Quoted 4 lines

The "-M" flag isn't the default, simply because it generates patches that cannot be applied with regular "patch", but for something like this, I think it's practically imperative. The old kind of "remove file" + "add file" patch just isn't acceptable when there are very viable alternaties.

I wish I knew this before breaking it up. But I'm sure I can do
another big patch and automate these updates :)

-- Steve