Skip to contentSkip to conversation

question on irqs and memory ordering

linux-usb-devel Alan Stern 1 participant 1 message Mar 14, 2007 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Alan Stern

author
#1 lore raw
Quoted 24 lines · Oliver Neukum

Hi,

I am looking at this code:

	if (new_msr &
	    (MOS_MSR_DELTA_CTS | MOS_MSR_DELTA_DSR | MOS_MSR_DELTA_RI |
	     MOS_MSR_DELTA_CD)) {
		icount = &mos7840_port->icount;

		/* update input line counters */
		if (new_msr & MOS_MSR_DELTA_CTS) {
			icount->cts++;
		}
		if (new_msr & MOS_MSR_DELTA_DSR) {
			icount->dsr++;
		}
		if (new_msr & MOS_MSR_DELTA_CD) {
			icount->dcd++;
		}
		if (new_msr & MOS_MSR_DELTA_RI) {
			icount->rng++;
		}
	}
Quoted 3 lines

It is called in interrupt and uses no locking. What happens if the next irq is processed on another cpu? Is that cpu guaranteed to see the updates to the incremented variables?

I _think_ it's okay. Taking an interrupt and returning from an interrupt ought to have explicit or implicit memory barriers.

It wouldn't hurt to ask someone else. David Howells wrote Documentation/memory-barriers.txt so maybe he knows. (The document itself doesn't say one way or the other.)

Alan Stern